Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GEP-19] Extend health checks of gardener-resource-manager for new Prometheus and Alertmanager resources #9163

Merged
merged 6 commits into from
Feb 15, 2024
Merged

[GEP-19] Extend health checks of gardener-resource-manager for new Prometheus and Alertmanager resources #9163

merged 6 commits into from
Feb 15, 2024

Conversation

rfranzke
Copy link
Member

How to categorize this PR?

/area monitoring ops-productivity
/kind enhancement

What this PR does / why we need it:
Extend health and progressing checks of gardener-resource-manager for new Prometheus and Alertmanager resources.

Which issue(s) this PR fixes:
Part of #9065

Release note:

`gardener-resource-manager` now considers the health and the progressing status for `Prometheus` and `Alertmanager` resources managed via `ManagedResource`s.

@gardener-prow gardener-prow bot added area/monitoring Monitoring (including availability monitoring and alerting) related area/ops-productivity Operator productivity related (how to improve operations) kind/enhancement Enhancement, improvement, extension labels Feb 12, 2024
@rfranzke rfranzke mentioned this pull request Feb 12, 2024
Closed
46 tasks
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 12, 2024
@shafeeqes
Copy link
Contributor

/assign

shafeeqes
shafeeqes requested changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@shafeeqes shafeeqes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR, thanks!

pkg/resourcemanager/controller/health/progressing/add.go Show resolved Hide resolved
pkg/resourcemanager/controller/health/progressing/reconciler.go Outdated Show resolved Hide resolved
test/integration/resourcemanager/health/health_suite_test.go Show resolved Hide resolved
shafeeqes
shafeeqes reviewed Feb 13, 2024
View reviewed changes
Copy link
Contributor

@shafeeqes shafeeqes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2024
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Feb 13, 2024

LGTM label has been added.

Git tree hash: 17979b8924ed0fd5b3b03c28f8eae0ea89f2c232

ary1992
ary1992 reviewed Feb 15, 2024
View reviewed changes
Copy link
Contributor

@ary1992 ary1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

pkg/utils/kubernetes/health/monitoring_test.go Outdated Show resolved Hide resolved
@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2024
@ary1992
Copy link
Contributor

ary1992 commented Feb 15, 2024

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2024
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Feb 15, 2024

LGTM label has been added.

Git tree hash: 408eda0ea45750c873d77b9b71331733a0bfab5e

@shafeeqes
Copy link
Contributor

/approve

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Feb 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shafeeqes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2024
@gardener-prow gardener-prow bot merged commit 99837c9 into gardener:master Feb 15, 2024
16 checks passed
@rfranzke rfranzke deleted the grm-health-checks branch February 16, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acumino acumino Awaiting requested review from acumino

@shafeeqes shafeeqes Awaiting requested review from shafeeqes

@ary1992 ary1992 Awaiting requested review from ary1992

Assignees

@ary1992 ary1992

@shafeeqes shafeeqes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/monitoring Monitoring (including availability monitoring and alerting) related area/ops-productivity Operator productivity related (how to improve operations) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rfranzke @shafeeqes @ary1992