Add container resource policies for HA VPN containers to hvpa resource of kube-apiserver. #9173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e of kube-apiserver. In the past, autoscaling of VPN side car containers was disabled in kube-apiserver. With the removal of the old VPN solution this code disappeared. The HA VPN solution did not influence the autoscaling of its containers in kube-apiserver. This can lead to situations where the memory resources are so restricted by VPA that even runc fails to start. Therefore, it is crucial to set minimum allowed values for memory so that the containers can always start. This change achieves exactly that.
gardener-prow
bot
added
area/auto-scaling
gardener-prow
bot
added
the
size/S
|
LGTM label has been added. Git tree hash: 5dbc0297d3a044e1f4e62132e05c9d051a415e2c
|
gardener-prow
bot
requested review from
danielfoehrKn,
marwinski and
MrBatschner
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MartinWeindel, rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
|
@voelzmo, @rfranzke, @ScheererJ, @MartinWeindel This pullrequest was referenced by someone in a duplicate issue. Details redacted in public. Check backend logs. |
|
@voelzmo, @rfranzke, @ScheererJ, @MartinWeindel This pullrequest was referenced by someone in a duplicate issue. Details redacted in public. Check backend logs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area auto-scaling
/area control-plane
/area networking
/area robustness
/kind enhancement
What this PR does / why we need it:
Add container resource policies for HA VPN containers to hvpa resource of kube-apiserver.
In the past, autoscaling of VPN side car containers was disabled in kube-apiserver. With the removal of the old VPN solution this code disappeared. The HA VPN solution did not influence the autoscaling of its containers in kube-apiserver. This can lead to situations where the memory resources are so restricted by VPA that even runc fails to start. Therefore, it is crucial to set minimum allowed values for memory so that the containers can always start.
This change achieves exactly that.
Which issue(s) this PR fixes:
None.
Special notes for your reviewer:
Release note: