Handle multiple potentially overlapping wildcard ingress domains in istio. #9183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-prow
bot
added
area/networking
gardener-prow
bot
added
cla: yes
…stio. With PR gardener#9038, nginx was moved behind the istio ingress gateway. The same PR also enabled management of multiple ingress domains via the `Garden` resource. Unfortunately, istio is a bit picky about overlapping domains in certain scenarios. This could lead to failing reconciliation of the nginx-ingress managed resource. Therefore, to prevent those situations this change splits the virtual services into separate instances per host so that istio does not complain and simply does the right thing.
ScheererJ
force-pushed
the
fix/handle-overlapping-ingress-domains
branch
from
faa6843
to
d97920c
Compare
|
/retest |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 30099f42ec30ffe388743d36988a32833a5ad6b2
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: plkokanov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area networking
/area robustness
/kind enhancement
What this PR does / why we need it:
Handle multiple potentially overlapping wildcard ingress domains in istio.
With PR #9038, nginx was moved behind the istio ingress gateway. The same PR also enabled management of multiple ingress domains via the
Gardenresource.Unfortunately, istio is a bit picky about overlapping domains in certain scenarios. This could lead to failing reconciliation of the nginx-ingress managed resource.
Therefore, to prevent those situations this change splits the virtual services into separate instances per host so that istio does not complain and simply does the right thing.
Which issue(s) this PR fixes:
None.
Special notes for your reviewer:
Release note: