Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to skip minor kubernetes versions for worker pool's kubernetes version upgrade #9185

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

shafeeqes
Copy link
Contributor

@shafeeqes shafeeqes commented Feb 20, 2024

How to categorize this PR?

/area usability
/kind enhancement

What this PR does / why we need it:
This PR relaxes the validation for worker pool kubernetes version upgrade to allow skipping minor versions.
See #9184 for detailed reasoning.

Which issue(s) this PR fixes:
Fixes #9184

Special notes for your reviewer:

Release note:

It is now possible to skip a minor Kubernetes version for worker pool Kubernetes version upgrades as long as the version remains equal to or less than the control plane version.

@gardener-prow gardener-prow bot added area/usability Usability related kind/enhancement Enhancement, improvement, extension labels Feb 20, 2024
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 20, 2024
@rfranzke
Copy link
Member

/assign

Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @shafeeqes, thanks for picking it up and implementing it so fast :)

pkg/apis/core/validation/shoot.go Outdated Show resolved Hide resolved
pkg/apis/core/validation/shoot.go Outdated Show resolved Hide resolved
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2024
Copy link
Contributor

gardener-prow bot commented Feb 20, 2024

LGTM label has been added.

Git tree hash: ac9920f27fa576806b146e503fe2b16f47c6684b

Copy link
Contributor

gardener-prow bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2024
@gardener-prow gardener-prow bot merged commit 12db245 into gardener:master Feb 20, 2024
16 checks passed
@shafeeqes shafeeqes deleted the enh/workerk8s branch February 26, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/usability Usability related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to skip minor K8s versions when upgrading a worker group's K8s version
2 participants