[GEP-19] Migrate aggregate Prometheus deployment and configuration #9200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-prow
bot
added
area/dev-productivity
46 tasks
gardener-prow
bot
added
size/XXL
rfranzke
force-pushed
the
gep19/aggregate-prometheus
branch
from
3720257
to
875e090
Compare
gardener-prow
bot
added
needs-rebase
`Ingress`, rules and configs are still missing. Will follow in separate commits.
rfranzke
force-pushed
the
gep19/aggregate-prometheus
branch
from
875e090
to
eadc93d
Compare
gardener-prow
bot
removed
the
needs-rebase
The `metering.rules.stateful.yaml` file is exactly the same as used in the cache Prometheus. There is a bash script generating it (https://github.com/gardener/gardener/blob/master/pkg/component/monitoring/prometheus/cache/assets/prometheusrules/metering.rules.stateful.sh). Let's simply copy it from there and reuse it.
We use a `ScrapeConfig` resource here because we explicitly want to have the `role=service` in the `kubernetes_sd_configs`
We already follow this approach for optimizing the transitive imports for other components, see - pkg/component/coredns/constants - pkg/component/etcd/constants - pkg/component/kubeapiserver/constants - pkg/component/nodelocaldns/constants - pkg/component/resourcemanager/constants - pkg/component/vpa/constants Without this, we would introduce some undesired transitive package imports, requiring to update the skaffold config: ``` >> Checking defined dependencies in Skaffold config 'provider-local' for 'gardener-extension-provider-local' in 'skaffold.yaml'... >>> The following actual dependencies are missing (need to be added): pkg/component/etcd pkg/component/etcd/constants pkg/component/monitoring pkg/component/monitoring/alertmanager pkg/component/monitoring/prometheus pkg/component/monitoring/prometheus/cache >>> The following dependencies are not needed actually (need to be removed): >>> Run './hack/update-skaffold-deps.sh' to fix. >> Checking defined dependencies in Skaffold config 'gardenlet' for 'gardener-node-agent' in 'skaffold.yaml'... >>> The following actual dependencies are missing (need to be added): pkg/component/etcd pkg/component/etcd/constants pkg/component/monitoring pkg/component/monitoring/alertmanager pkg/component/monitoring/prometheus pkg/component/monitoring/prometheus/cache pkg/extensions pkg/utils/kubernetes/unstructured >> Checking defined dependencies in Skaffold config 'gardener-operator' for 'gardener-operator' in 'skaffold-operator.yaml'... >>> The following actual dependencies are missing (need to be added): pkg/component/monitoring pkg/component/monitoring/alertmanager pkg/component/monitoring/prometheus >>> The following dependencies are not needed actually (need to be removed): >>> Run './hack/update-skaffold-deps.sh' to fix. ``` This approach actually allows us to drop some package dependencies.
rfranzke
force-pushed
the
gep19/aggregate-prometheus
branch
from
eadc93d
to
594573d
Compare
|
/assign |
ScheererJ
reviewed
Feb 22, 2024
|
LGTM label has been added. Git tree hash: 53303ded216535207b1afe4f3fa29b429f9e473f
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area dev-productivity monitoring
/kind enhancement
What this PR does / why we need it:
Similar to #9128 and #9180, this PR migrates management of the aggregate Prometheus deployment and its configuration to
prometheus-operator.The learnings/follow-ups from #9189 and #9195 are already incorporated.
Which issue(s) this PR fixes:
Part of #9065
Special notes for your reviewer:
/cc @oliver-goetz @ScheererJ
FYI @istvanballok @rickardsjp
Release note:
It is now possible to provide configuration for the aggregate Prometheus running in seed clusters' `garden` namespaces. Read all about it [here](https://github.com/gardener/gardener/tree/master/docs/extensions/logging-and-monitoring.md#aggregate-prometheus).