Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote UseGardenerNodeAgent feature gate to GA #9208

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

rfranzke
Copy link
Member

How to categorize this PR?

/area open-source
/kind enhancement

What this PR does / why we need it:
Promote UseGardenerNodeAgent feature gate to GA and lock it to its default value (true).

Which issue(s) this PR fixes:
Part of #8023

Special notes for your reviewer:
/cc @oliver-goetz

Release note:

The `UseGardenerNodeAgent` feature gate has been promoted to GA. It was already enabled by default and can now no longer be turned off. The feature gate will be removed in a future release.

@gardener-prow gardener-prow bot added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 23, 2024
@gardener-prow gardener-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 23, 2024
@gardener-prow gardener-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 23, 2024
@rfranzke rfranzke force-pushed the promote/gna branch 2 times, most recently from 8e07814 to bbaeece Compare February 23, 2024 09:09
Copy link
Member

@oliver-goetz oliver-goetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🚀
Next release a big bash cleanup can be done 🧹

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2024
Copy link
Contributor

gardener-prow bot commented Feb 23, 2024

LGTM label has been added.

Git tree hash: 9c1c62a5d072de5b92a1ba406f0821400f230cd0

Copy link
Contributor

gardener-prow bot commented Feb 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oliver-goetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2024
@rfranzke
Copy link
Member Author

Next release a big bash cleanup can be done 🧹

Not yet, we have to wait for another grace period to allow the OS extensions to adapt :)

@gardener-prow gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 23, 2024
When the feature gate is removed, the remaining unit tests and production code are adapted.
We cannot do it now because we still need the code for migration from CCD -> GNA in case somebody turned off the `UseGardenerNodeAgent` (was possible before, but is no longer possible now with GA promotion).
@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2024
@gardener-prow gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 23, 2024
@rfranzke
Copy link
Member Author

@oliver-goetz
Copy link
Member

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2024
Copy link
Contributor

gardener-prow bot commented Feb 23, 2024

LGTM label has been added.

Git tree hash: 22d52cf0eb3599bc9e50db2360b3a8337b61180f

@gardener-prow gardener-prow bot merged commit 85f4424 into gardener:master Feb 23, 2024
17 checks passed
@rfranzke rfranzke deleted the promote/gna branch February 26, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants