-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote UseGardenerNodeAgent
feature gate to GA
#9208
Conversation
84191c5
to
30bd0eb
Compare
8e07814
to
bbaeece
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 🚀
Next release a big bash cleanup can be done 🧹
/lgtm
LGTM label has been added. Git tree hash: 9c1c62a5d072de5b92a1ba406f0821400f230cd0
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oliver-goetz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Not yet, we have to wait for another grace period to allow the OS extensions to adapt :) |
When the feature gate is removed, the remaining unit tests and production code are adapted. We cannot do it now because we still need the code for migration from CCD -> GNA in case somebody turned off the `UseGardenerNodeAgent` (was possible before, but is no longer possible now with GA promotion).
bbaeece
to
b9a1dd5
Compare
FYI, related PRs:
|
/lgtm |
LGTM label has been added. Git tree hash: 22d52cf0eb3599bc9e50db2360b3a8337b61180f
|
How to categorize this PR?
/area open-source
/kind enhancement
What this PR does / why we need it:
Promote
UseGardenerNodeAgent
feature gate to GA and lock it to its default value (true
).Which issue(s) this PR fixes:
Part of #8023
Special notes for your reviewer:
/cc @oliver-goetz
Release note: