Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve package structure #9217

Merged
merged 15 commits into from
Feb 29, 2024
Merged

Improve package structure #9217

merged 15 commits into from
Feb 29, 2024

Conversation

rfranzke
Copy link
Member

How to categorize this PR?

/area dev-productivity
/kind enhancement

What this PR does / why we need it:

  • Move monitoring-related components to pkg/component/monitoring/*
  • Move Gardener components to pkg/component/gardener/*
  • Move autoscaling-related components to pkg/component/autoscaling/*
  • Move networking-related components to pkg/component/networking/*
  • Move Garden cluster-related components to pkg/component/garden/*
  • Move Seed cluster-related components to pkg/component/seed/*
  • Move Shoot cluster-related components to pkg/component/shoot/*
  • Move node mgmt-related components to pkg/component/nodemanagement/*
  • Move observability-related components to pkg/component/observability/*
  • Move etcd-related components to pkg/component/etcd/*
  • Move Kubernetes components to pkg/component/kubernetes/*
  • Move pkg/envtest to test/envtest
  • Move pkg/mock to third_party/mock
  • Move pkg/{openapi,registry} packages to pkg/apiserver/*
  • Move pkg/operation to pkg/gardenlet/operation

Release note:

The `pkg/envtest` package has been moved to `test/envtest`. Most component packages in `pkg/component` have been moved. The `pkg/openapi` and `pkg/registry` packages have been moved to `pkg/apiserver/*`.

@gardener-prow gardener-prow bot added area/dev-productivity Developer productivity related (how to improve development) kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Feb 23, 2024
@gardener-prow gardener-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 23, 2024
@acumino
Copy link
Member

acumino commented Feb 26, 2024

/assign

@gardener-prow gardener-prow bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 26, 2024
@rfranzke rfranzke force-pushed the move-pkg branch 2 times, most recently from 2572a2a to 720276f Compare February 27, 2024 09:42
@gardener-prow gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 27, 2024
@plkokanov
Copy link
Contributor

I managed to go through most of the commits, and plan to try out the PR locally as well.

I just have one question for now - is the nodemanagement/* location ok for the dependency-watchdog? It seems to fit the prober component of the dependency-watchdog, but not the weeder.
As an alternative, I could suggest using the seed/* directory, but don't really have too strong of an opinion.

@plkokanov
Copy link
Contributor

/assign

@gardener-prow gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 27, 2024
@rfranzke
Copy link
Member Author

I managed to go through most of the commits, and plan to try out the PR locally as well.

I just have one question for now - is the nodemanagement/* location ok for the dependency-watchdog? It seems to fit the prober component of the dependency-watchdog, but not the weeder. As an alternative, I could suggest using the seed/* directory, but don't really have too strong of an opinion.

I think it shouldn't matter much - I'd prefer to keep it as is since DWD's main task is preventing massive node terminations when getting unavailable.

@gardener-prow gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 27, 2024
@gardener-prow gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 27, 2024
@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2024
@gardener-prow gardener-prow bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 28, 2024
@gardener-prow gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 29, 2024
Copy link
Member

@acumino acumino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 29, 2024
Copy link
Contributor

gardener-prow bot commented Feb 29, 2024

LGTM label has been added.

Git tree hash: b7f8cf61aef4921158b15fadc502b5593072678d

@gardener-prow gardener-prow bot merged commit ed35517 into gardener:master Feb 29, 2024
17 checks passed
@rfranzke rfranzke deleted the move-pkg branch February 29, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dev-productivity Developer productivity related (how to improve development) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants