Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set correct labels to shoot prometheus vpa #9244

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Set correct labels to shoot prometheus vpa #9244

merged 1 commit into from
Feb 26, 2024

Conversation

nickytd
Copy link
Contributor

@nickytd nickytd commented Feb 26, 2024 •
edited by rfranzke

/area monitoring
/kind enhancement

This PR sets labels to shoot prometheu vpa, aligned with the statefulset.

The `VerticalPodAutoscaler` object for the shoot Prometheus is now labeled with `app=prometheus,role=monitoring`, similar to the corresponding `StatefulSet`.

@gardener-prow gardener-prow bot added the area/monitoring Monitoring (including availability monitoring and alerting) related label Feb 26, 2024
@gardener-prow gardener-prow bot added the kind/enhancement Enhancement, improvement, extension label Feb 26, 2024
@gardener-prow gardener-prow bot requested a review from timuthy February 26, 2024 06:47
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 26, 2024
@rfranzke
Copy link
Member

/assign

rfranzke
rfranzke reviewed Feb 26, 2024
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2024
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Feb 26, 2024

LGTM label has been added.

Git tree hash: 241e4f0c4946da9ee8d12fd8fb7cd68b69601ee2

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Feb 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2024
@gardener-prow gardener-prow bot merged commit 7889fb9 into gardener:master Feb 26, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke left review comments

@ScheererJ ScheererJ Awaiting requested review from ScheererJ

@timuthy timuthy Awaiting requested review from timuthy

Assignees

@rfranzke rfranzke

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/monitoring Monitoring (including availability monitoring and alerting) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nickytd @rfranzke