-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cpu target percentile parameter to VPA options in Shoot spec #9279
Add cpu target percentile parameter to VPA options in Shoot spec #9279
Conversation
/hold running some experiments to verify this has the desired effect |
f43a186
to
623125f
Compare
623125f
to
daa3ad5
Compare
daa3ad5
to
bb8d263
Compare
/retest |
PR looks good, but adaptation in https://github.com/gardener/gardener/blob/master/docs/usage/shoot_autoscaling.md#vertical-pod-auto-scaling is still missing. |
Ah, sorry, thanks for catching that I missed that. |
bb8d263
to
c8aeae3
Compare
We could. OTOH, the API docs typically do not contain too much information. Maybe this works in case of the VPA fields - if so, feel free to just link the generated docs (maybe in a separate PR). /lgtm |
LGTM label has been added. Git tree hash: 8e12fdab4f4492df3f9ce1935384df1fe9774ac6
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
How to categorize this PR?
/area auto-scaling
/kind enhancement
What this PR does / why we need it:
This PR exposes the
targetCPUPercentile
parameter of the VPA recommender in the Shoot spec. With this parameter, Shoot owners or gardener operators can fine-tune the recommender behavior regarding recommendations for CPU.The default is 0.9, which means the recommender will issue a recommendation that is fulfilling 90% of the observed CPU measurements. As CPU is a compressible resource, Shoot owner may want to set this to a smaller value, depending on the headroom on their nodes and the requirements for their workloads.
Release note: