-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[node-agent] Introduce hostname-check
controller
#9280
Conversation
Co-Authored-By: Oliver Götz <47362717+oliver-goetz@users.noreply.github.com>
Co-Authored-By: Oliver Götz <47362717+oliver-goetz@users.noreply.github.com>
Co-Authored-By: Oliver Götz <47362717+oliver-goetz@users.noreply.github.com>
1e0b4ef
to
8a2fce6
Compare
/cherry-pick release-v1.89 |
@rfranzke: once the present PR merges, I will cherry-pick it on top of release-v1.89 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-v1.88 |
/cherry-pick release-v1.87 |
@rfranzke: once the present PR merges, I will cherry-pick it on top of release-v1.88 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rfranzke: once the present PR merges, I will cherry-pick it on top of release-v1.87 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
awesome 🚀 |
LGTM label has been added. Git tree hash: 16191e75c27071003c52c203b1ad39cd721a020d
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oliver-goetz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rfranzke: new pull request created: #9286 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rfranzke: new pull request created: #9287 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rfranzke: new pull request created: #9288 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
How to categorize this PR?
/area usability
/kind bug
What this PR does / why we need it:
With this PR, a new
hostname-check
controller is introduced. It periodically (each30s
) checks if the hostname of the nodegardener-node-agent
runs on has changed compared to what it has read during its start-up. If a change is detected, it calls the cancel function of the root context, leading to a termination and an eventual restart of thegardener-node-agent
systemd
unit.Motivation: We have seen cases where the hostname has changed for some nodes. Without this,
gardener-node-agent
will stuck forever ingardener/pkg/nodeagent/controller/operatingsystemconfig/reconciler.go
Lines 155 to 158 in 76704c3
gardener/pkg/nodeagent/controller/add.go
Lines 36 to 39 in 76704c3
Which issue(s) this PR fixes:
Part of #8023
Follow-up of #9114
Special notes for your reviewer:
/cc @oliver-goetz @ialidzhikov
Release note: