Add IP Stack to DNSRecord resources
#9289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-prow
bot
added
area/networking
|
/assign |
|
LGTM label has been added. Git tree hash: 57ba8cf916b8035a08bc625e9cf1dfec5678acdb
|
rfranzke
reviewed
Feb 29, 2024
gardener-prow
bot
added
needs-rebase
ScheererJ
force-pushed
the
enhancement/dns-record-ip-stack
branch
from
15751b0
to
dcc60da
Compare
gardener-prow
bot
removed
the
needs-rebase
|
LGTM label has been added. Git tree hash: 1bb7266e8201d3010e1ad7c1f1b376611a940709
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MartinWeindel, rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area networking
/kind enhancement
What this PR does / why we need it:
For some DNS providers it might be beneficial to know the IP stack of the actual DNS record, e.g. ipv4 for
Arecords and ipv4 forAAAArecords. This is especially true forCNAMErecords, which are an alias for another name. Some DNS providers allow shortcuts, i.e. other means to achieve the equivalent of aCNAMErecord, but need knowledge about the target record's type. For those scenarios, it can be helpful to have the target IP stack directly available at the DNS record so that the corresponding DNS provider can directly use the information instead of having to query DNS to resolve theCNAMErecord.This pull requests adds an annotation to the DNS records depending on the
IPFamilyof the shoot/seed clusters. This allows DNS providers to act accordingly.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:
/cc @MartinWeindel