Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v1.90] Consider errors from configValidator for ErrorCodes #9321

Merged
merged 1 commit into from
Mar 6, 2024
Merged

[release-v1.90] Consider errors from configValidator for ErrorCodes #9321

merged 1 commit into from
Mar 6, 2024

Conversation

gardener-ci-robot
Copy link
Contributor

@gardener-ci-robot gardener-ci-robot commented Mar 5, 2024 •
edited

This is an automated cherry-pick of #9266

/assign acumino

Function signature of infrastructure controller `NewReconciler` has changed from `NewReconciler(manager.Manager, Actuator, ConfigValidator)` to NewReconciler(manager.Manager, Actuator, ConfigValidator, map[gardencorev1beta1.ErrorCode]func(string) bool).

@gardener-ci-robot gardener-ci-robot mentioned this pull request Mar 5, 2024
Merged
@gardener-ci-robot gardener-ci-robot added kind/enhancement Enhancement, improvement, extension area/ops-productivity Operator productivity related (how to improve operations) labels Mar 5, 2024
@gardener-prow gardener-prow bot added the cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. label Mar 5, 2024
@gardener-prow gardener-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 5, 2024
acumino
acumino reviewed Mar 6, 2024
View reviewed changes
Copy link
Member

@acumino acumino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest
/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2024
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Mar 6, 2024

LGTM label has been added.

Git tree hash: b2608203d3b33e7c7d68822a7f21f2bf89aa0e42

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Mar 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acumino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2024
@gardener-prow gardener-prow bot merged commit acf1c59 into gardener:release-v1.90 Mar 6, 2024
16 checks passed
@gardener-ci-robot gardener-ci-robot deleted the cherry-pick-9266-to-release-v1.90 branch March 6, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acumino acumino acumino left review comments

@ialidzhikov ialidzhikov Awaiting requested review from ialidzhikov

@timuthy timuthy Awaiting requested review from timuthy

Assignees

@acumino acumino

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ops-productivity Operator productivity related (how to improve operations) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gardener-ci-robot @acumino