Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v1.90] [GEP-19] [shoot-care] Check for alertmanager-shoot when Gardener >= 1.90 #9340

Merged
merged 1 commit into from
Mar 8, 2024
Merged

[release-v1.90] [GEP-19] [shoot-care] Check for alertmanager-shoot when Gardener >= 1.90 #9340

merged 1 commit into from
Mar 8, 2024

Conversation

gardener-ci-robot
Copy link
Contributor

@gardener-ci-robot gardener-ci-robot commented Mar 8, 2024 •
edited

This is an automated cherry-pick of #9335

/assign rfranzke

A bug has been fixed which reported false negative health checks for the `ObservabilityComponentsHealthy` condition on `Shoot`s using Alertmanager if they have been reconciled with Gardener `>= 1.90`.

@gardener-ci-robot gardener-ci-robot mentioned this pull request Mar 8, 2024
Merged
@gardener-ci-robot gardener-ci-robot added the area/ops-productivity Operator productivity related (how to improve operations) label Mar 8, 2024
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 8, 2024
ScheererJ
ScheererJ approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2024
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Mar 8, 2024

LGTM label has been added.

Git tree hash: 4fcd89de65531f3a3caf451beb38e09a07c067f3

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Mar 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ScheererJ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2024
@gardener-prow gardener-prow bot merged commit bbabd81 into gardener:release-v1.90 Mar 8, 2024
16 checks passed
@gardener-ci-robot gardener-ci-robot deleted the cherry-pick-9335-to-release-v1.90 branch March 8, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScheererJ ScheererJ ScheererJ approved these changes

@ary1992 ary1992 Awaiting requested review from ary1992

@timebertt timebertt Awaiting requested review from timebertt

Assignees

@rfranzke rfranzke

@ScheererJ ScheererJ

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ops-productivity Operator productivity related (how to improve operations) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/bug Bug lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gardener-ci-robot @ScheererJ @rfranzke