[release-v1.90] [GEP-19] Add namespace to value of PVC migration label in PersistentVolumes

[gardener-ci-robot]

This is an automated cherry-pick of #9338

/assign rfranzke

A bug has been fixed which prevented `Shoot`s using Alertmanager from getting stuck in reconciliation with error `last error: more than one PV found with label disk-migration.monitoring.gardener.cloud/pvc-name=alertmanager-db-alertmanager-0`.

[ScheererJ]

/lgtm
/approve

[gardener-prow]

LGTM label has been added.

Git tree hash: 0d9789ff2e6adf223c9cb5f0c9ab83b16a0df666

[gardener-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ScheererJ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ScheererJ]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gardener-prow]

@gardener-ci-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-gardener-e2e-kind-upgrade-release-v1-90	e190f42	link	true	/test pull-gardener-e2e-kind-upgrade-release-v1-90
pull-gardener-e2e-kind-migration-release-v1-90	e190f42	link	true	/test pull-gardener-e2e-kind-migration-release-v1-90
pull-gardener-e2e-kind-ha-multi-zone-upgrade-release-v1-90	e190f42	link	true	/test pull-gardener-e2e-kind-ha-multi-zone-upgrade-release-v1-90
pull-gardener-e2e-kind-ha-single-zone-upgrade-release-v1-90	e190f42	link	true	/test pull-gardener-e2e-kind-ha-single-zone-upgrade-release-v1-90

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[rfranzke]

/close

Seems we have to use a different separator/mechanism:

2024-03-08T13:48:14.211267688Z stderr F {"level":"error","ts":"2024-03-08T13:48:14.211Z","msg":"Reconciler error","controller":"seed","namespace":"","name":"local-ha-single-zone","reconcileID":"124aaa89-f037-4531-a26d-07fdf1adc548","error":"1 error occurred:\n\t* task \"Deploying aggregate Prometheus\" failed: failed patching PV /pvc-3097db07-c084-4253-a932-94376eb741e8: PersistentVolume \"pvc-3097db07-c084-4253-a932-94376eb741e8\" is invalid: metadata.labels: Invalid value: \"garden/prometheus-db-aggregate-prometheus-0\": a valid label must be an empty string or consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue',  or 'my_value',  or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?')\n\n","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\tsigs.k8s.io/controller-runtime@v0.17.2/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\tsigs.k8s.io/controller-runtime@v0.17.2/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\tsigs.k8s.io/controller-runtime@v0.17.2/pkg/internal/controller/controller.go:227"}

[gardener-prow]

@rfranzke: Closed this PR.

In response to this:

/close

Seems we have to use a different separator/mechanism:

2024-03-08T13:48:14.211267688Z stderr F {"level":"error","ts":"2024-03-08T13:48:14.211Z","msg":"Reconciler error","controller":"seed","namespace":"","name":"local-ha-single-zone","reconcileID":"124aaa89-f037-4531-a26d-07fdf1adc548","error":"1 error occurred:\n\t* task \"Deploying aggregate Prometheus\" failed: failed patching PV /pvc-3097db07-c084-4253-a932-94376eb741e8: PersistentVolume \"pvc-3097db07-c084-4253-a932-94376eb741e8\" is invalid: metadata.labels: Invalid value: \"garden/prometheus-db-aggregate-prometheus-0\": a valid label must be an empty string or consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue',  or 'my_value',  or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?')\n\n","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\tsigs.k8s.io/controller-runtime@v0.17.2/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\tsigs.k8s.io/controller-runtime@v0.17.2/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\tsigs.k8s.io/controller-runtime@v0.17.2/pkg/internal/controller/controller.go:227"}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.