Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kcContext.auth no longer being set correctly #121

Closed
bplotnick opened this issue Jun 19, 2022 · 5 comments
Closed

kcContext.auth no longer being set correctly #121

bplotnick opened this issue Jun 19, 2022 · 5 comments

Comments

@bplotnick
Copy link

Typically kcContext.auth contains fields like showTryAnotherWayLink, which allows users to pick auth methods. However, as of v5.0.0, this is no longer working as kcContext.auth is being set as false.

This is easily reproducible - 1) directly observe the value or 2) try with multiple auth methods - the built-in theme will have the link but the keycloakify theme will not.

I've narrowed this down to starting in v5.0.0, but i haven't been able to determine why it is happening.

@garronej
Copy link
Collaborator

Thank you for reporting, there is indeed an error on keycloakify's side.
I doubt it's the bump to v5 that causes it though....

@bplotnick
Copy link
Author

bplotnick commented Jun 19, 2022 via email

@garronej
Copy link
Collaborator

garronej commented Jun 19, 2022

I found the guilty commit.
It's the bump from 5.3.2 -> 5.4.0

garronej added a commit that referenced this issue Jun 19, 2022
@garronej
Copy link
Collaborator

@bplotnick it's fixed in latest release,
Thanks for reporting!

@bplotnick
Copy link
Author

I must've messed up my bisect somehow. Glad you tracked down the issue. I've confirmed that I can't repro the issue anymore. Thanks @garronej!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants