Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform regex is missing upercase letters #90

Closed
valkum opened this issue Apr 22, 2022 · 1 comment
Closed

Transform regex is missing upercase letters #90

valkum opened this issue Apr 22, 2022 · 1 comment

Comments

@valkum
Copy link

valkum commented Apr 22, 2022

Thanks for your work. We currently are evaluating the usage of keycloakify but see some errors.

Currently the transform of resource paths fails because the regex is only using lowercase letters for the replace matching.

Our tooling outputs something like this Ai=Nt.p+"static/media/start-meeting-ill.... thus the replace only matches t.p+"static leading to a replacement to Nwindow... which will obviously fail.

If you agree that a simple fix would be to add upper case letters, I can probably offer a patch

garronej added a commit that referenced this issue Apr 22, 2022
@garronej
Copy link
Collaborator

Hi @valkum,
It should be fixed now. (v4.8.4)
Thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants