Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add login-idp-link-email page #92

Merged
merged 3 commits into from Apr 25, 2022
Merged

feat: add login-idp-link-email page #92

merged 3 commits into from Apr 25, 2022

Conversation

Tasyp
Copy link
Collaborator

@Tasyp Tasyp commented Apr 22, 2022

Adds login-idp-link-email.ftl page.

However, there is one issue. In the original template, the code looks like the following:

${msg("emailLinkIdp1", idpAlias, brokerContext.username, realm.displayName)}

Is it possible to somehow access the brokerContext inside kecloakify?

Copy link
Collaborator

@garronej garronej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @Tasyp,
Than you for your contribution!
Would you mind trying with the following suggestions?

src/lib/components/LoginIdpLinkEmail.tsx Outdated Show resolved Hide resolved
src/lib/components/LoginIdpLinkEmail.tsx Outdated Show resolved Hide resolved
src/lib/getKcContext/KcContextBase.ts Outdated Show resolved Hide resolved
@Tasyp
Copy link
Collaborator Author

Tasyp commented Apr 25, 2022

@garronej thanks for your quick feedback!

I have addressed your feedback. It should look good now

@garronej
Copy link
Collaborator

Looks great, thank you very much for your contribution, it is much appreciated.

@garronej garronej merged commit ac99e2f into keycloakify:main Apr 25, 2022
@garronej
Copy link
Collaborator

a new version incorporating your contribution has been released

@Tasyp Tasyp deleted the add-login-idp-link-email branch April 25, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants