Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build 7x slowers between 4.8.3 and 4.8.4 #99

Closed
Romcol opened this issue May 3, 2022 · 2 comments · Fixed by #101
Closed

Build 7x slowers between 4.8.3 and 4.8.4 #99

Romcol opened this issue May 3, 2022 · 2 comments · Fixed by #101

Comments

@Romcol
Copy link
Contributor

Romcol commented May 3, 2022

Hi!

When trying to upgrade keycloakify I noticed that the build is much slower now.
The first version which has made the issue arises is 4.8.4.

Timing my project

Version 4.8.3 : 0m28,849s
Version 4.8.4 : 3m35,671s

As we can see here v4.8.3...v4.8.4, probably this file src/bin/build-keycloak-theme/replaceImportFromStatic.ts is to blame. There are some changes in regexes that may be slower to process.

I have tried on several versions of node (v16.14.2, v12.22.11, ...) but it is the same.

Do you have any idea?

Thanks 🙏
@garronej
Copy link
Collaborator

garronej commented May 3, 2022

Hi @Romcol,
Thanks for reporting.
It must be 0e194ee
related to #90

Feel free to submit a PR.

Romcol added a commit to Romcol/keycloakify that referenced this issue May 4, 2022
@Romcol
[IMP] Issue keycloakify#99 - Make replace less greedy in remplaceImpo…
6595e9c 
…rtFromStatic
@Romcol Romcol mentioned this issue May 4, 2022
Merged
@Romcol
Copy link
Contributor Author

Romcol commented May 4, 2022

Hi,
Indeed. I made a pull request :)

garronej added a commit that referenced this issue May 4, 2022
@garronej
Merge pull request #101 from Romcol/bugfix/99
dde9afe 
Issue #99 - Make replace less greedy in remplaceImportFromStatic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #99 - Make replace less greedy in remplaceImportFromStatic Romcol/keycloakify
2 participants
@Romcol @garronej