Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow overrides in nginx configuration #33

Open
gunzip opened this issue Nov 18, 2019 · 2 comments · May be fixed by #45
Open

allow overrides in nginx configuration #33

gunzip opened this issue Nov 18, 2019 · 2 comments · May be fixed by #45

Comments

@gunzip
Copy link

gunzip commented Nov 18, 2019

as the configuration file is set now, it is impossible to http add headers because the hardcoded location directives precede the customization part. I propose to put the custom environment variable $CUSTOM_SERVER_CONFIG before the location sections.

@gatsbot
Copy link

gatsbot bot commented Nov 18, 2019

@gunzip We noticed that the body of this issue is blank.

Please fill in this field with more information to help the maintainers resolve your issue.

Generated by 🚫 dangerJS

@gunzip gunzip changed the title allow allow overrides in ngnix configuration Nov 18, 2019
@gunzip gunzip changed the title allow overrides in ngnix configuration allow overrides in nginx configuration Nov 18, 2019
@torenware
Copy link
Contributor

Could you give an example of an override you'd want to do, and where in the resulting nginx config file it would need to be? You can see the file that gets generated by running:

docker run -rm IMAGE_NAME cat /etc/nginx/mushed.conf

One serious limitation here is that nginx won't let you duplicate a setting in a block; it will quit with an error rather than start. So overrides may not be possible doing what we're doing nginx-boot.sh script that we're using to handle the customizations. But if I know what you're trying to do, we can figure out if this is the way to do it.

@Giggiux Giggiux linked a pull request Nov 12, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants