Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: gatsbyjs/gatsby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: gatsby@3.11.0
Choose a base ref
...
head repository: gatsbyjs/gatsby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: gatsby@3.11.1
Choose a head ref
  • 4 commits
  • 13 files changed
  • 4 contributors

Commits on Aug 9, 2021

  1. feat(gatsby): allow sites to disable the dev 404 page (#32686) (#32745) 

    This is mostly useful when using the dev server to run a preview instance where you
don't want the dev-focused 404 page.

(cherry picked from commit af5525e)

Co-authored-by: Kyle Mathews <mathews.kyle@gmail.com>
    @KyleAMathews
    GatsbyJS Bot and KyleAMathews authored Aug 9, 2021

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    54d3315 View commit details

  2. fix(gatsby): Silence process.send Error (#32744) (#32747) 

    Co-authored-by: Lennart <lekoarts@gmail.com>
    @LekoArts
    GatsbyJS Bot and LekoArts authored Aug 9, 2021
    Copy the full SHA
    ac7c641 View commit details

  3. fix(contentful): base64 previews now reflect all query options (#32709)… 

    … (#32746)

Co-authored-by: Benedikt Rötsch <axe312ger@users.noreply.github.com>
Co-authored-by: LekoArts <lekoarts@gmail.com>
    @axe312ger @LekoArts
    3 people authored Aug 9, 2021
    Copy the full SHA
    4f8d93b View commit details

  4. chore(release): Publish 

     - gatsby-admin@0.21.1
 - gatsby-source-contentful@5.11.1
 - gatsby@3.11.1
    @LekoArts
    LekoArts committed Aug 9, 2021
    Copy the full SHA
    a7cd1d6 View commit details
14 changes: 7 additions & 7 deletions e2e-tests/contentful/cypress/integration/gatsby-image.js
View file
Original file line number Diff line number Diff line change
@@ -13,11 +13,11 @@ function hasSVGPlaceholder(el) {
})
}

function hasJPEGPlaceholder(el) {
function hasBase64Placeholder(el) {
el.children(`img`)
.should(`have.attr`, `src`)
.and(src => {
expect(src).to.match(/^data:image\/jpeg/)
expect(src).to.match(/^data:image\/[a-z]+;base64/)
})
}

@@ -49,21 +49,21 @@ describe(`gatsby-image`, () => {
beforeEach(() => {
cy.visit("/gatsby-image").waitForRouteChange()
})
it(`fluid`, testConfig, () => testGatsbyImage(`fluid`, hasJPEGPlaceholder))
it(`fixed`, testConfig, () => testGatsbyImage(`fixed`, hasJPEGPlaceholder))
it(`webp`, testConfig, () => testGatsbyImage(`webp`, hasJPEGPlaceholder))
it(`fluid`, testConfig, () => testGatsbyImage(`fluid`, hasBase64Placeholder))
it(`fixed`, testConfig, () => testGatsbyImage(`fixed`, hasBase64Placeholder))
it(`webp`, testConfig, () => testGatsbyImage(`webp`, hasBase64Placeholder))
it(`traced`, testConfig, () => testGatsbyImage(`traced`, hasSVGPlaceholder))
it(`sqip`, testConfig, () => testGatsbyImage(`sqip`, hasSVGPlaceholder))

it(`english`, testConfig, () => {
testGatsbyImage(`english`, hasJPEGPlaceholder)
testGatsbyImage(`english`, hasBase64Placeholder)
cy.get(`[data-cy="english"] p strong`).should(
"have.text",
"Locale - American English (png)"
)
})
it(`german`, testConfig, () => {
testGatsbyImage(`german`, hasJPEGPlaceholder)
testGatsbyImage(`german`, hasBase64Placeholder)
cy.get(`[data-cy="german"] p strong`).should(
"have.text",
"Locale - German (png)"
6 changes: 3 additions & 3 deletions e2e-tests/contentful/cypress/integration/gatsby-plugin-image.js
View file
Original file line number Diff line number Diff line change
@@ -13,11 +13,11 @@ function hasSVGPlaceholder(el) {
})
}

function hasJPEGPlaceholder(el) {
function hasBase64Placeholder(el) {
el.children(`img`)
.should(`have.attr`, `src`)
.and(src => {
expect(src).to.match(/^data:image\/jpeg;base64/)
expect(src).to.match(/^data:image\/[a-z]+;base64/)
})
}

@@ -77,7 +77,7 @@ describe(`gatsby-plugin-image`, () => {
testGatsbyPluginImage(`traced`, hasSVGPlaceholder)
)
it(`blurred`, testConfig, () =>
testGatsbyPluginImage(`blurred`, hasJPEGPlaceholder)
testGatsbyPluginImage(`blurred`, hasBase64Placeholder)
)
it(`sqip`, testConfig, () => testGatsbyPluginImage(`sqip`, hasSVGPlaceholder))

Loading