Watch for changes to html.js #1473

felixjung · 2017-07-11T22:26:21Z

Addresses #1442.

@KyleAMathews, I think we can address the configuration via socket support in a separate topic branch?

gatsbybot · 2017-07-11T22:31:13Z

Deploy preview ready!

Built with commit ee15e2c

https://deploy-preview-1473--using-drupal.netlify.com

gatsbybot · 2017-07-11T22:31:56Z

Deploy preview ready!

Built with commit ee15e2c

https://deploy-preview-1473--gatsbygram.netlify.com

KyleAMathews · 2017-07-11T22:33:50Z

Won't StaticSiteGeneratorPlugin automatically rebuild all pages?

No check out develop-html.js — it only builds one index.html page.

The only thing I see right now is to include socket.io and push an event to the client whenever index.html has been rebuilt. The client can then refresh the page.

Yeah exactly. Gatsby's entry for development would connect to the dev server and then would refresh when instructed.

KyleAMathews · 2017-07-11T22:34:02Z

Looking good so far!

gatsbybot · 2017-07-11T22:37:44Z

Deploy preview ready!

Built with commit ee15e2c

https://deploy-preview-1473--gatsbyjs.netlify.com

KyleAMathews · 2017-07-12T07:54:26Z

Deploy preview failed.

Built with commit ee15e2c

https://app.netlify.com/sites/using-styled-components/deploys/5967ea667960b10804296eb5

KyleAMathews · 2017-07-12T07:54:43Z

Deploy preview failed.

Built with commit d607b3e81176053c02993fc66685579218834d0e

https://app.netlify.com/sites/using-glamor/deploys/5965d5216f4c507bc0303652

KyleAMathews · 2017-07-12T07:55:23Z

Deploy preview failed.

Built with commit 1c2b4a1101cde779e723007cde9320364fb7206e

https://app.netlify.com/sites/using-postcss-sass/deploys/59669e7b424ef23c4ea8996e

KyleAMathews · 2017-07-12T07:56:20Z

Deploy preview failed.

Built with commit d607b3e81176053c02993fc66685579218834d0e

https://app.netlify.com/sites/image-processing/deploys/5965d5216f4c507bc030364f

KyleAMathews · 2017-07-12T07:56:35Z

Deploy preview failed.

Built with commit ee15e2c

https://app.netlify.com/sites/using-contentful/deploys/5967ea667960b10804296eb8

felixjung · 2017-07-12T19:27:40Z

OK. This works end-to-end now. @KyleAMathews, I'm not sure if I put the client code in the right places. Could you review the code please? ☺️

felixjung · 2017-07-12T19:32:56Z

Hah, I guess I still have to add some tests 😉

KyleAMathews

Looks great!

Tests would be fantastic too!

KyleAMathews · 2017-07-12T20:02:33Z

packages/gatsby/src/cache-dir/app.js

@@ -8,6 +8,13 @@ window.___emitter = require(`./emitter`)
 // Let the site/plugins run code very early.
 apiRunner(`onClientEntry`)

+if (process.env.NODE_ENV === `development`) {


This isn't necessary as this file is only used in development.

Ah, good to know. I wasn't sure, but I guess I should have taken a closer look at the webpack config 😁

felixjung · 2017-07-12T20:38:23Z

I've added tests for the src/util/path.js module. I have 0️⃣ clue how to test the develop server though 😞 That being said, I don't see too many tests in there anyway 😂

felixjung · 2017-07-13T08:15:12Z

Wow, getting those windows tests right took longer than it should have 🙄

KyleAMathews · 2017-07-13T22:33:16Z

Just tested it, worked perfectly! Slick work!

The only change I'd suggest making is to add a console.log when Gatsby starts rebuilding the html.js file so the user knows something is happening and why.

KyleAMathews · 2017-07-13T22:34:00Z

I'm going to do another minor release now and want this in it so I'll just merge this but please do the above in a follow-up PR.

Thanks for taking this on! Hot reload all the things :-)

felixjung · 2017-07-14T04:47:33Z

Woohoo! Yeah, what you say makes a lot of sense 😀.

This fails on Windows. Doing a check for filename validity on Windows [is costly](https://github.com/sindresorhus/filename-reserved-regex/blob/master/index.js) and should probably be done by the user but in this case if the file doesn't exists then so does the link. Surrounding this with a `try...catch` solves the issue with no further consequences. This should be solved once [libuv v2.0](https://github.com/libuv/libuv) will be out. Report of the error : ``` fs.js:1103 return binding.unlink(pathModule._makeLong(path)); ^ Error: ENOENT: no such file or directory, unlink 'C:\{your-path}\public\render-page.js' at Error (native) at Object.fs.unlinkSync (fs.js:1103:18) at C:\{your-path}\node_modules\gatsby\dist\utils\develop-html.js:59:30 at Compiler.<anonymous> (C:\{your-path}\node_modules\webpack\lib\Compiler.js:194:14) at Compiler.emitRecords (C:\{your-path}\node_modules\webpack\lib\Compiler.js:282:37) at Compiler.<anonymous> (C:\{your-path}\node_modules\webpack\lib\Compiler.js:187:11) at C:\{your-path}\node_modules\webpack\lib\Compiler.js:275:11 at Compiler.applyPluginsAsync (C:\{your-path}\node_modules\tapable\lib\Tapable.js:60:69) at Compiler.afterEmit (C:\{your-path}\node_modules\webpack\lib\Compiler.js:272:8) at Compiler.<anonymous> (C:\{your-path}\node_modules\webpack\lib\Compiler.js:267:14) at C:\{your-path}\node_modules\webpack\node_modules\async\lib\async.js:52:16 at done (C:\{your-path}\node_modules\webpack\node_modules\async\lib\async.js:246:17) at C:\{your-path}\node_modules\webpack\node_modules\async\lib\async.js:44:16 at C:\{your-path}\node_modules\graceful-fs\graceful-fs.js:43:10 at FSReqWrap.oncomplete (fs.js:123:15) ``` Related to #1473 #1442

jlengstorf · 2019-02-16T20:08:08Z

Hiya @felixjung! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

felixjung · 2019-02-16T21:50:55Z

Thanks a ton @jlengstorf! I had heard about this in various podcasts, but wasn’t expecting it anymore. What a nice surprise. Keep it up!

Felix Jung added 8 commits July 12, 2017 20:07

Remove unused lodash import.

00c0bce

Rebuild index.html on changes to html.js.

19a7d06

Add withBasePath() helper function.

59a8641

Use withBasePath in webpack config.

639be5e

Also watch gatsby-ssr files with chokidar.

4a3d895

Use directoryPath in develop.js.

31731f9

Emit "reload" event to connected clients via socket.io.

27b871c

Reload page on client if "reload" event is received.

04e9b0b

KyleAMathews reviewed Jul 12, 2017

View reviewed changes

Felix Jung added 2 commits July 12, 2017 22:32

Move socket.io code into its own module.

8c01966

Add tests for path module.

cb40b96

Fix and extend tests for path module.

292134b

Merge branch 'master' into topic/watch-changes-to-html-js

ee15e2c

KyleAMathews merged commit 7ed0389 into gatsbyjs:master Jul 13, 2017

felixjung mentioned this pull request Jul 20, 2017

Gatsby does not detect/render changes to html.js #1442

Closed

sebastienfi mentioned this pull request Aug 2, 2017

Update built-html.js fixin fs.unlinkSync() error #1694

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Watch for changes to html.js #1473

Watch for changes to html.js #1473

felixjung commented Jul 11, 2017 •

edited

gatsbybot commented Jul 11, 2017 •

edited

gatsbybot commented Jul 11, 2017 •

edited

KyleAMathews commented Jul 11, 2017

KyleAMathews commented Jul 11, 2017

gatsbybot commented Jul 11, 2017 •

edited

KyleAMathews commented Jul 12, 2017 •

edited

KyleAMathews commented Jul 12, 2017

KyleAMathews commented Jul 12, 2017 •

edited

KyleAMathews commented Jul 12, 2017

KyleAMathews commented Jul 12, 2017 •

edited

felixjung commented Jul 12, 2017

felixjung commented Jul 12, 2017

KyleAMathews left a comment

KyleAMathews Jul 12, 2017

felixjung Jul 12, 2017

felixjung commented Jul 12, 2017

felixjung commented Jul 13, 2017

KyleAMathews commented Jul 13, 2017

KyleAMathews commented Jul 13, 2017

felixjung commented Jul 14, 2017

jlengstorf commented Feb 16, 2019

felixjung commented Feb 16, 2019

Watch for changes to html.js #1473

Watch for changes to html.js #1473

Conversation

felixjung commented Jul 11, 2017 • edited

gatsbybot commented Jul 11, 2017 • edited

gatsbybot commented Jul 11, 2017 • edited

KyleAMathews commented Jul 11, 2017

KyleAMathews commented Jul 11, 2017

gatsbybot commented Jul 11, 2017 • edited

KyleAMathews commented Jul 12, 2017 • edited

KyleAMathews commented Jul 12, 2017

KyleAMathews commented Jul 12, 2017 • edited

KyleAMathews commented Jul 12, 2017

KyleAMathews commented Jul 12, 2017 • edited

felixjung commented Jul 12, 2017

felixjung commented Jul 12, 2017

KyleAMathews left a comment

Choose a reason for hiding this comment

KyleAMathews Jul 12, 2017

Choose a reason for hiding this comment

felixjung Jul 12, 2017

Choose a reason for hiding this comment

felixjung commented Jul 12, 2017

felixjung commented Jul 13, 2017

KyleAMathews commented Jul 13, 2017

KyleAMathews commented Jul 13, 2017

felixjung commented Jul 14, 2017

jlengstorf commented Feb 16, 2019

felixjung commented Feb 16, 2019

felixjung commented Jul 11, 2017 •

edited

gatsbybot commented Jul 11, 2017 •

edited

gatsbybot commented Jul 11, 2017 •

edited

gatsbybot commented Jul 11, 2017 •

edited

KyleAMathews commented Jul 12, 2017 •

edited

KyleAMathews commented Jul 12, 2017 •

edited

KyleAMathews commented Jul 12, 2017 •

edited