use program directory over cwd #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview ready! Built with commit a2881df |
|
Deploy preview failed. Built with commit a2881df https://app.netlify.com/sites/gatsbygram/deploys/5965b36b8ebdd913649a6c69 |
|
Deploy preview ready! Built with commit a2881df |
|
Thanks! |
| @@ -88,7 +88,7 @@ async function startServer(program) { | |||
| app.use((req, res, next) => { | |||
| const parsedPath = parsePath(req.originalUrl) | |||
| if (parsedPath.extname === `` || parsedPath.extname === `.html`) { | |||
| res.sendFile(`${process.cwd()}/public/index.html`, err => { | |||
| res.sendFile(`${program.directory()}/public/index.html`, err => { | |||
There was a problem hiding this comment.
This seems to be incorrect as program.directory is not a function. gatsby-dev-cli is breaking for me because of this. I'll fix in a PR shortly.
There was a problem hiding this comment.
Ah yea, that's my bad! Thanks for PR'ing the fix 👍
There was a problem hiding this comment.
Interesting that some of the CI deploys worked? Looks like we have may have false positives.
KyleAMathews
pushed a commit
that referenced
this pull request
Jul 13, 2017
This PR had a small typo #1478
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.