Added support for nested img tags in html nodes #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview failed. Built with commit 149441b https://app.netlify.com/sites/using-styled-components/deploys/5966a079cf321c79dbf87323 |
|
Deploy preview ready! Built with commit 149441b |
|
Deploy preview ready! Built with commit 149441b |
|
Deploy preview ready! Built with commit 149441b |
|
This plugin is getting kinda complex but with no tests yet. Doesn't need to go in this PR but we need a way to mock gatsby-plugin-sharp so we can write tests with it. Perhaps just disable actually creating images when in test mode. |
|
Haha agreed. I just put that on my todo list after I finish moving my other sites to Gatsby 1.0 and then finish a couple small client projects that have been building up. |
|
Awesome thanks! Looking forward to the tests!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While migrating some of my larger sites over to Gatsby I noticed that my initial solution for html image tags didn't work nested img tags.
This would work
This would not work
This should now work for both.