Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-plugin-netlify-cms): add custom favicon to cms section #14883

Merged
merged 2 commits into from Jul 12, 2019

Conversation

chrisjpatty
Copy link
Contributor

Description

This pull request adds the ability to define an optional favicon field in the plugin, gatsby-plugin-netlify-cms. It leverages the favicon option defined by the HTML Webpack Plugin. I've also updated the relevant documentation page describing how to add the property.

This is my first PR to this repo, let me know if there's anything additional you need to review this PR, thanks!

@chrisjpatty chrisjpatty requested a review from a team as a code owner June 18, 2019 19:59
@chrisjpatty chrisjpatty changed the title Addes the ability to define a favicon in the netlify-cms app Addes the ability to define a favicon in gatsby-plugin-netlify-cms Jun 18, 2019
@chrisjpatty chrisjpatty changed the title Addes the ability to define a favicon in gatsby-plugin-netlify-cms Adds the ability to define a favicon in gatsby-plugin-netlify-cms Jun 19, 2019
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works 👍

i've tested it with https://github.com/netlify-templates/gatsby-starter-netlify-cms
image

@wardpeet wardpeet changed the title Adds the ability to define a favicon in gatsby-plugin-netlify-cms feat(gatsby-plugin-netlify-cms): add custom favicon to cms section Jul 12, 2019
@wardpeet wardpeet merged commit 2cf13ae into gatsbyjs:master Jul 12, 2019
@gatsbot
Copy link

gatsbot bot commented Jul 12, 2019

Holy buckets, @chrisjpatty — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@wardpeet
Copy link
Contributor

Published in gatsby-plugin-netlify-cms@4.1.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants