New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure pathPrefix is added to responsive images #1510

Merged

KyleAMathews merged 1 commit into gatsbyjs:master from DSchau:prefix-path

Jul 19, 2017

Contributor

DSchau commented Jul 14, 2017 •

edited

Add pathPrefix to the responsive image plugin in gatsby-remark-sharp

Note: I'll add tests and that kind of thing, but I'm correct in assuming there aren't any tests for this plugin currently, correct?

If so, looks like you expect them in packages/gatsby-remark-images/src/__tests__/, and that's where I should start editing them?


          fix: ensure pathPrefix is added to responsive images

dd13dcc

Fixes gatsbyjs#1505

Contributor

KyleAMathews commented Jul 14, 2017

Deploy preview failed.

Built with commit dd13dcc

https://app.netlify.com/sites/using-styled-components/deploys/596911c8cf321c6f2df82bd4

Collaborator

gatsbybot commented Jul 14, 2017

Deploy preview ready!

Built with commit dd13dcc

https://deploy-preview-1510--gatsbygram.netlify.com

Collaborator

gatsbybot commented Jul 14, 2017

Deploy preview ready!

Built with commit dd13dcc

https://deploy-preview-1510--using-drupal.netlify.com

Collaborator

gatsbybot commented Jul 14, 2017

Deploy preview ready!

Built with commit dd13dcc

https://deploy-preview-1510--gatsbyjs.netlify.com

Contributor

KyleAMathews commented Jul 19, 2017

Yeah, tests should be in src/__tests__/. I'll merge this now as it's a unfortunate/unneeded bugs but would love some tests as well!

KyleAMathews merged commit 43e8cd1 into gatsbyjs:master

Contributor Author

DSchau commented Jul 19, 2017

I'll write some in a future PR! Thanks for merging!

Contributor

jlengstorf commented Feb 16, 2019

Hiya @DSchau! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment