Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs referencing outdated React Router <Link> API #1523

Merged

Conversation

andrewagain
Copy link
Contributor

@andrewagain andrewagain commented Jul 16, 2017

The current docs reference this react-router page which is outdated. For instance it mentions the onlyActiveOnIndex prop which does not exist anymore in react-router.

@KyleAMathews
Copy link
Contributor

KyleAMathews commented Jul 16, 2017

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jul 16, 2017

Deploy preview ready!

Built with commit 2192f4e

https://deploy-preview-1523--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jul 16, 2017

Deploy preview ready!

Built with commit 2192f4e

https://deploy-preview-1523--gatsbyjs.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jul 16, 2017

Deploy preview ready!

Built with commit 2192f4e

https://deploy-preview-1523--gatsbygram.netlify.com

@KyleAMathews
Copy link
Contributor

Ah nice! Yeah definitely needed updating.

Could we just link to their master branch though instead of a commit?

@andrewagain
Copy link
Contributor Author

@KyleAMathews changed!

@KyleAMathews
Copy link
Contributor

Perfect, thanks!

@KyleAMathews KyleAMathews merged commit fda379d into gatsbyjs:master Jul 18, 2017
@jlengstorf
Copy link
Contributor

Hiya @ahfarmer! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants