Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Ready for merge) Adds showcase segment for starters/websites built with Gatsby. #1535

Merged
merged 15 commits into from Jul 19, 2017

Conversation

Vagr9K
Copy link
Contributor

@Vagr9K Vagr9K commented Jul 17, 2017

Since, presumably, most people will be browsing github/npm readmes first, I have decided to include the "Showcase" segment in README.md.

Also, in contrary to the v0 showcase, this one also will include general features of starters listed under their bullet points. That will make finding implementations of different features (tags/categories/GA) easier.

I'm working on the website list right now. Unfortunately it seems like there are only 4 v1 starters available currently.

I'll make sure this will be ready for merging tomorrow.

@KyleAMathews
Copy link
Contributor

KyleAMathews commented Jul 17, 2017

@KyleAMathews
Copy link
Contributor

Deploy preview failed.

Built with commit d827758

https://app.netlify.com/sites/image-processing/deploys/596d1d59424ef201f3fb9ce5

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jul 17, 2017

Deploy preview ready!

Built with commit d44d785

https://deploy-preview-1535--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jul 17, 2017

Deploy preview ready!

Built with commit d44d785

https://deploy-preview-1535--gatsbyjs.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jul 17, 2017

Deploy preview ready!

Built with commit d44d785

https://deploy-preview-1535--gatsbygram.netlify.com

@KyleAMathews
Copy link
Contributor

Let's not put the starters on the GitHub README. Perhaps mention there that starters exist and link to the website page for starters but let's focus the GitHub README on marketing and push people to the website for actual documentation.

We should have a curated list of impressive Gatsby websites there for marketing however.

@Vagr9K
Copy link
Contributor Author

Vagr9K commented Jul 17, 2017

Maybe a separate page in the docs for starters?

We should have a curated list of impressive Gatsby websites there for marketing however.

And another one on gatsbyjs.org for websites? Or this one can go into README for marketing?

I'll create the list for now, and then actually append them to pages based on your feedback.

@Vagr9K
Copy link
Contributor Author

Vagr9K commented Jul 18, 2017

@KyleAMathews I've separated starters into a different page in the documents. Should I do the same for websites?

Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

README.md Outdated
* [Segment's Blog](https://segment.com/blog/)
* [Fabric](https://meetfabric.com/)
* [Formidable](https://formidable.com/)
* [ResonML Docs](https://reasonml.github.io/) [(source)](https://github.com/reasonml/reasonml.github.io)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

README.md Outdated
* [ResonML Docs](https://reasonml.github.io/) [(source)](https://github.com/reasonml/reasonml.github.io)
* [Jamie Henson's Blog](http://jamiehenson.com/) [(source)](https://github.com/jamiehenson/jh47-gatsby)
* [Sean Coker's Blog](https://sean.is/)
* [Dustin Schau's Blog](https://dustinschau.com/blog/) [(source)](https://github.com/dschau/blog)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add meetfabric.com as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meetfabric.com is there. Maybe you mean sources?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, oops missed it.

gatsby new https://github.com/gatsbyjs/gatsby-starter-blog my-log
```

Currently available starters:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kill this line. It's redundant because if a starter isn't here it isn't currently available ;-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point...

title: 'Gatsby Starters'
---

GatsbyJS starters are premade projects packed with features which can be used for accelerating development speed. They are also a great source for learning about implementations of different features.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -6,6 +6,7 @@
Querying with GraphQL*: /docs/querying-with-graphql/
Gatsby Lifecycle APIs: /docs/gatsby-lifecycle-apis/
Deploying: /docs/deploy-gatsby/
Gatsby Starters: /docs/gatsby-starters
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make this "Starters". Also remove "Gatsby" from "Gatsby Lifecycle APIs". The Gatsby part is obvious in these.

@@ -44,6 +44,8 @@ class IndexRoute extends React.Component {
testing your built site.
</li>
</ol>
<h2>Using a GatbsyJS starter</h2>
<p>You can also use one of the premade <Link to="/docs/gatsby-starters/">Gatsby starters</Link> to save time, or learn about the possible usages of Gatsby in production. Starters are also great examples of feature implementations!</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about a little more streamlined text here:

<h2>Using other starters</h2>
<p>Running <code>gatsby new</code> installs the default Gatsby starter. There are <Link to="/docs/gatsby-starters/">many other official and community starters</Link> you can use to kickstart building your Gatsby site.</p>

@Vagr9K
Copy link
Contributor Author

Vagr9K commented Jul 18, 2017

All requested fixes are here.
Note: The last starter tries to solve the issue of starters being either way too opinionated about UI or too basic.
I also want it to become a good learning resource for the newcomers, so we can refer them to code samples that don't contain hundreds of lines of UI logic. Sorting out questions about GA/Tags/Categories/RSS/SEO/Semi-Dynamic content should be easier.

I hope there are no issues with me having 2 starters on this list?

@Vagr9K Vagr9K changed the title (WIP) Adds showcase segment for starters/websites built with Gatsby. (Ready for merge) Adds showcase segment for starters/websites built with Gatsby. Jul 18, 2017
@KyleAMathews
Copy link
Contributor

Deploy preview failed.

Built with commit 365f949

https://app.netlify.com/sites/using-remark/deploys/596e95fe8ebdd9219050f379

@KyleAMathews
Copy link
Contributor

KyleAMathews commented Jul 18, 2017

issues with me having 2 starters on this list?

Eventually we'll move this to a searchable, faceted, paginated list where you could have 100 starters if you felt like it :-)

@Vagr9K
Copy link
Contributor Author

Vagr9K commented Jul 18, 2017

Do you prefer merging this now or waiting a little bit more to gather more sites/starters?

@KyleAMathews
Copy link
Contributor

Merging now. You/others can add starters as they're found/made. 10 little PRs / day are way better than 10 big PRs / week.

@KyleAMathews KyleAMathews merged commit 6d589b3 into gatsbyjs:master Jul 19, 2017
@fk
Copy link
Contributor

fk commented Jul 19, 2017

@Vagr9K Nice PR and cool advanced starter! 👍 👍 👍
Three things I spotted:

@fk
Copy link
Contributor

fk commented Jul 19, 2017

Oh, and somehow the two spaces necessary for some of the line breaks examples went missing (probably because your editor strips end of line whitespace, see #1441 (comment)).

@KyleAMathews
Copy link
Contributor

@Vagr9K
Copy link
Contributor Author

Vagr9K commented Jul 19, 2017

@fk Thanks for spotting those issues :)
Should be fixed by now.
As for the unexpected line break issue, I already had plans to integrate MD linter into the project, but now It's extra high on my list of priorities...
Thanks again!

@fk
Copy link
Contributor

fk commented Jul 19, 2017

@Vagr9K You're welcome, happy to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants