New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Ready for merge) Adds showcase segment for starters/websites built with Gatsby. #1535
Conversation
Deploy preview failed. Built with commit 0ac2c8c https://app.netlify.com/sites/using-styled-components/deploys/596d5d567960b146c1477b27 |
Deploy preview failed. Built with commit d827758 https://app.netlify.com/sites/image-processing/deploys/596d1d59424ef201f3fb9ce5 |
Deploy preview ready! Built with commit d44d785 |
Deploy preview ready! Built with commit d44d785 |
Deploy preview ready! Built with commit d44d785 |
Let's not put the starters on the GitHub README. Perhaps mention there that starters exist and link to the website page for starters but let's focus the GitHub README on marketing and push people to the website for actual documentation. We should have a curated list of impressive Gatsby websites there for marketing however. |
Maybe a separate page in the docs for starters?
And another one on I'll create the list for now, and then actually append them to pages based on your feedback. |
@KyleAMathews I've separated starters into a different page in the documents. Should I do the same for websites? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
README.md
Outdated
* [Segment's Blog](https://segment.com/blog/) | ||
* [Fabric](https://meetfabric.com/) | ||
* [Formidable](https://formidable.com/) | ||
* [ResonML Docs](https://reasonml.github.io/) [(source)](https://github.com/reasonml/reasonml.github.io) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo
README.md
Outdated
* [ResonML Docs](https://reasonml.github.io/) [(source)](https://github.com/reasonml/reasonml.github.io) | ||
* [Jamie Henson's Blog](http://jamiehenson.com/) [(source)](https://github.com/jamiehenson/jh47-gatsby) | ||
* [Sean Coker's Blog](https://sean.is/) | ||
* [Dustin Schau's Blog](https://dustinschau.com/blog/) [(source)](https://github.com/dschau/blog) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add meetfabric.com as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meetfabric.com is there. Maybe you mean sources?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right, oops missed it.
docs/docs/gatsby-starters.md
Outdated
gatsby new https://github.com/gatsbyjs/gatsby-starter-blog my-log | ||
``` | ||
|
||
Currently available starters: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kill this line. It's redundant because if a starter isn't here it isn't currently available ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point...
docs/docs/gatsby-starters.md
Outdated
title: 'Gatsby Starters' | ||
--- | ||
|
||
GatsbyJS starters are premade projects packed with features which can be used for accelerating development speed. They are also a great source for learning about implementations of different features. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just use my old intro from the v0-README
https://github.com/gatsbyjs/gatsby/blob/master/v0-README.md#gatsby-starters
www/src/pages/docs/doc-links.yaml
Outdated
@@ -6,6 +6,7 @@ | |||
Querying with GraphQL*: /docs/querying-with-graphql/ | |||
Gatsby Lifecycle APIs: /docs/gatsby-lifecycle-apis/ | |||
Deploying: /docs/deploy-gatsby/ | |||
Gatsby Starters: /docs/gatsby-starters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just make this "Starters". Also remove "Gatsby" from "Gatsby Lifecycle APIs". The Gatsby part is obvious in these.
www/src/pages/docs/index.js
Outdated
@@ -44,6 +44,8 @@ class IndexRoute extends React.Component { | |||
testing your built site. | |||
</li> | |||
</ol> | |||
<h2>Using a GatbsyJS starter</h2> | |||
<p>You can also use one of the premade <Link to="/docs/gatsby-starters/">Gatsby starters</Link> to save time, or learn about the possible usages of Gatsby in production. Starters are also great examples of feature implementations!</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about a little more streamlined text here:
<h2>Using other starters</h2>
<p>Running <code>gatsby new</code> installs the default Gatsby starter. There are <Link to="/docs/gatsby-starters/">many other official and community starters</Link> you can use to kickstart building your Gatsby site.</p>
All requested fixes are here. I hope there are no issues with me having 2 starters on this list? |
Deploy preview failed. Built with commit 365f949 https://app.netlify.com/sites/using-remark/deploys/596e95fe8ebdd9219050f379 |
Eventually we'll move this to a searchable, faceted, paginated list where you could have 100 starters if you felt like it :-) |
Do you prefer merging this now or waiting a little bit more to gather more sites/starters? |
Merging now. You/others can add starters as they're found/made. 10 little PRs / day are way better than 10 big PRs / week. |
@Vagr9K Nice PR and cool advanced starter! 👍 👍 👍
|
Oh, and somehow the two spaces necessary for some of the line breaks examples went missing (probably because your editor strips end of line whitespace, see #1441 (comment)). |
Deploy preview failed. Built with commit d44d785 https://app.netlify.com/sites/using-postcss-sass/deploys/596ea1b1cf321c731fb614f3 |
@fk Thanks for spotting those issues :) |
@Vagr9K You're welcome, happy to help! |
Since, presumably, most people will be browsing github/npm readmes first, I have decided to include the "Showcase" segment in README.md.
Also, in contrary to the v0 showcase, this one also will include general features of starters listed under their bullet points. That will make finding implementations of different features (tags/categories/GA) easier.
I'm working on the website list right now. Unfortunately it seems like there are only 4 v1 starters available currently.
I'll make sure this will be ready for merging tomorrow.