Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing sw.js 404-ing because of pathPrefix not being prefixed to sw.js properly. Fixing #1539 #1540

Merged
merged 2 commits into from Jul 19, 2017

Conversation

gregsqueeb
Copy link
Contributor

The pathPrefix does not include the trailing slash so we have to make sure to include it so that sw.js gets loaded properly and does not 404

The pathPrefix does not include the trailing slash so we have to make sure to include it so that sw.js gets loaded properly and does not 404
@gregsqueeb gregsqueeb changed the title Fixing #1539 Fixing sw.js 404-ing because of pathPrefix not being prefixed to sw.js properly. Fixing #1539 Jul 18, 2017
@gatsbybot
Copy link
Collaborator

gatsbybot commented Jul 18, 2017

Deploy preview failed.

Built with commit cf13675

https://app.netlify.com/sites/gatsbygram/deploys/596e1365424ef2511915c301

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jul 18, 2017

Deploy preview ready!

Built with commit cf13675

https://deploy-preview-1540--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jul 18, 2017

Deploy preview failed.

Built with commit cf13675

https://app.netlify.com/sites/gatsbyjs/deploys/596e1365424ef2511915c2fe

@KyleAMathews
Copy link
Contributor

Deploy preview failed.

Built with commit cf13675

https://app.netlify.com/sites/image-processing/deploys/596e1366424ef2511915c310

@KyleAMathews KyleAMathews merged commit 4480963 into gatsbyjs:master Jul 19, 2017
@jlengstorf
Copy link
Contributor

Hiya @gregsqueeb! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

@gregsqueeb
Copy link
Contributor Author

Oh wow cool! Thanks so much!

@jlengstorf
Copy link
Contributor

Hiya @gregsqueeb! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants