Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if node.value is set as otherwise cheerio throws an error #1543

Merged
merged 1 commit into from Jul 18, 2017

Conversation

KyleAMathews
Copy link
Contributor

No description provided.

@gatsbybot
Copy link
Collaborator

Deploy preview ready!

Built with commit ab171c4

https://deploy-preview-1543--gatsbyjs.netlify.com

@gatsbybot
Copy link
Collaborator

Deploy preview ready!

Built with commit ab171c4

https://deploy-preview-1543--using-drupal.netlify.com

@KyleAMathews
Copy link
Contributor Author

Deploy preview failed.

Built with commit ab171c4

https://app.netlify.com/sites/image-processing/deploys/596e6de08ebdd96b04637184

@KyleAMathews
Copy link
Contributor Author

Deploy preview failed.

Built with commit ab171c4

https://app.netlify.com/sites/gatsbygram/deploys/596e6ddf8ebdd96b0463717a

@KyleAMathews
Copy link
Contributor Author

@biilmann you asked a while ago about what types of errors we're seeing from preview builds on Netilfy. There seems to be two broad categories — random failures from upstreams so NPM or the service that's hosting the binaries for Sharp. The most common weird failures from Netlify are when builds just stall for no apparent reason and then hit the 15 minute timeout. That's what the gatsbygram & image-processing failures above seem to be from.

Both took ~7-8 minutes to run a step which normally takes ~2-3. Perhaps the build servers just got really busy for a bit? For both of those sites, the deploy preview built just fine.

@KyleAMathews
Copy link
Contributor Author

Using Remark lives again! https://596e6de08ebdd96b0463718c--using-remark.netlify.com/

@KyleAMathews KyleAMathews merged commit 052f021 into master Jul 18, 2017
@KyleAMathews KyleAMathews deleted the fix-using-remark branch July 18, 2017 21:09
@biilmann
Copy link

Thanks @KyleAMathews - we're looking into those!

@KyleAMathews
Copy link
Contributor Author

@biilmann also see this now and then where Netlify will report a failure while the site is still building. Just happened with this build https://app.netlify.com/sites/gatsbyjs/deploys/596eba25cf321c5f2fb6150f Reported a failure probably 5-8 minutes before it finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants