Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clone context to avoid possible mutations #1553

Merged
merged 1 commit into from Jul 19, 2017
Merged

Clone context to avoid possible mutations #1553

merged 1 commit into from Jul 19, 2017

Conversation

KyleAMathews
Copy link
Contributor

No description provided.

@KyleAMathews KyleAMathews mentioned this pull request Jul 19, 2017
Merged
@KyleAMathews KyleAMathews merged commit cb70f6c into master Jul 19, 2017
@KyleAMathews KyleAMathews deleted the clone-context branch July 19, 2017 06:29
@KyleAMathews
Copy link
Contributor Author

Deploy preview failed.

Built with commit ce577bd

https://app.netlify.com/sites/gatsbyjs/deploys/596ef8dc6f4c502f174cd2f2

@KyleAMathews
Copy link
Contributor Author

Deploy preview failed.

Built with commit ce577bd

https://app.netlify.com/sites/gatsbygram/deploys/596ef8dc6f4c502f174cd2f4

@gatsbybot
Copy link
Collaborator

Deploy preview failed.

Built with commit ce577bd

https://app.netlify.com/sites/using-drupal/deploys/596ef8dc6f4c502f174cd2f6

@KyleAMathews
Copy link
Contributor Author

Deploy preview failed.

Built with commit ce577bd

https://app.netlify.com/sites/image-processing/deploys/596ef8dc6f4c502f174cd2fe

@KyleAMathews
Copy link
Contributor Author

Deploy preview failed.

Built with commit ce577bd

https://app.netlify.com/sites/using-styled-components/deploys/596ef8dd6f4c502f174cd302

@KyleAMathews
Copy link
Contributor Author

Deploy preview failed.

Built with commit ce577bd

https://app.netlify.com/sites/using-glamor/deploys/596ef8dd6f4c502f174cd300

@KyleAMathews
Copy link
Contributor Author

Deploy preview failed.

Built with commit ce577bd

https://app.netlify.com/sites/using-contentful/deploys/596ef8dd6f4c502f174cd304

okcoker added a commit to okcoker/gatsby that referenced this pull request Jul 20, 2017
@okcoker
Revert "Clone context (gatsbyjs#1553)"
0e9d332 
This reverts commit cb70f6c.
KyleAMathews pushed a commit that referenced this pull request Jul 26, 2017
@okcoker @KyleAMathews
Create new page object when running dirty pages (#1537)
7b0248f 
* Dont mutate the nodes object

As noted on the lodash docs, this method is mutative https://lodash.com/docs/\#mergeWith

* Update tests

* Revert "Clone context (#1553)"

This reverts commit cb70f6c.

* Use cloneDeep instead
benmccormick pushed a commit to benmccormick/gatsby that referenced this pull request Jul 28, 2017
@okcoker
Create new page object when running dirty pages (gatsbyjs#1537)
2f89180 
* Dont mutate the nodes object

As noted on the lodash docs, this method is mutative https://lodash.com/docs/\#mergeWith

* Update tests

* Revert "Clone context (gatsbyjs#1553)"

This reverts commit cb70f6c.

* Use cloneDeep instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KyleAMathews @gatsbybot