Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gatsby-transformer-sharp: Added the option to use the original image #1556

Merged

Conversation

chiedo
Copy link

@chiedo chiedo commented Jul 19, 2017

Users who don't want Sharp to process anything now have that option.

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jul 19, 2017

Deploy preview ready!

Built with commit cf64ff5

https://deploy-preview-1556--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jul 19, 2017

Deploy preview ready!

Built with commit cf64ff5

https://deploy-preview-1556--gatsbyjs.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jul 19, 2017

Deploy preview ready!

Built with commit cf64ff5

https://deploy-preview-1556--gatsbygram.netlify.com

Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@@ -16,6 +16,11 @@ const {
} = require(`gatsby-plugin-sharp`)

const sharp = require(`sharp`)
const {promisify} = require('util');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a Node 8 only function. You can use https://www.npmjs.com/package/util.promisify

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added!

@KyleAMathews
Copy link
Contributor

Deploy preview failed.

Built with commit 188426f

https://app.netlify.com/sites/image-processing/deploys/596fd4bd8ebdd96cb87ffd70

@chiedo
Copy link
Author

chiedo commented Jul 19, 2017

Done with my changes. Passing again in my local tests :)

@KyleAMathews
Copy link
Contributor

Deploy preview failed.

Built with commit 188426f

https://app.netlify.com/sites/using-remark/deploys/596fd4be8ebdd96cb87ffd7c

@KyleAMathews KyleAMathews merged commit 375f2e7 into gatsbyjs:master Jul 25, 2017
@KyleAMathews
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants