add tests to gatsby-remark-images #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: This change is primarily related to testing, and shouldn't have any side effects
|
Deploy preview ready! Built with commit 6d65616 |
|
Deploy preview ready! Built with commit 6d65616 |
|
Deploy preview ready! Built with commit 6d65616 |
|
Deploy preview failed. Built with commit 3a3074d https://app.netlify.com/sites/using-contentful/deploys/596f8b1ca700c44c45258ee6 |
|
Tests! Nice! The tests look spot on. Snapshots are perfect for this sort of thing. Yeah, running |
|
Re-ran prettier! Let me know if you want me to squash those into one commit or something, otherwise I think this stuff is good to go |
|
Awesome! Merging |
|
I always squash so no worries there :-) |
|
Deploy preview failed. Built with commit 6d65616 https://app.netlify.com/sites/image-processing/deploys/596fa49a7960b12ad84b44b0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some basic unit tests (and snapshots) to gatsby-remark-images
Note: there's probably more we can do here, but it's a start! Let me know how it looks
One thing I may want to do is re-run prettier on the code base, so I can do that too