Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[www] Blog post meta styles #1561

Merged
merged 8 commits into from Jul 20, 2017
Merged

Conversation

fk
Copy link
Contributor

@fk fk commented Jul 19, 2017

On individual post pages, this reduces the author avatar size a little and gives the author info, post meta (and subsequently the post title) a little more room to breathe on Tablet and up:

image

For the blog index page, it consolidates author and post date in one line and adjusts typography to match the individual post styles, also reduces the author avatar size, and removes the dark green excerpt font color:

image

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jul 19, 2017

Deploy preview ready!

Built with commit eacb60d

https://deploy-preview-1561--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jul 19, 2017

Deploy preview ready!

Built with commit eacb60d

https://deploy-preview-1561--gatsbyjs.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jul 19, 2017

Deploy preview ready!

Built with commit eacb60d

https://deploy-preview-1561--gatsbygram.netlify.com

@KyleAMathews
Copy link
Contributor

Nice! I like the tweaks.

A couple of notes:

  • the new one-line on previews seems a touch too far
  • the front page blog post previews needs updated as well — perhaps create a blog post preview component? Have you seen query fragments as well? Would be a good fit for this new component.

@fk
Copy link
Contributor Author

fk commented Jul 19, 2017

the new one-line on previews seems a touch too far

👍 OK boss! ;-)

the front page blog post previews needs updated as well — perhaps create a blog post preview component?

Damn how could I forget those! Component it is.

Have you seen query fragments as well?

No :-/

@KyleAMathews
Copy link
Contributor

re query fragments, see the Relay docs https://facebook.github.io/relay/docs/fragment-container.html#composing-fragments

Basically a component can create a query fragment which is added to a global namespace and then normal queries can include the fragment. This is a perfect fit for problems like this where a component is used in multiple places and needs to ensure its data is provided as expected. It's obnoxious otherwise to have to keep the required fields in multiple places.

Florian Kissling added 2 commits July 19, 2017 19:31
…ar size"

This reverts commit d6576b7 and on top of that gets rid of <small> in favor of `scale` to compensate for Futura rendering a lot smaller than Gyre Schola.
@KyleAMathews
Copy link
Contributor

Sweet! Nice refactor :-) Love how clean the blog preview item component is with the fragment. Such a nice pattern. Composable declarative data ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants