Add gatsby-plugin-feed to www #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview failed. Built with commit 6a940c3 https://app.netlify.com/sites/using-drupal/deploys/5970eab7cf321c6cc955a7a9 |
|
Deploy preview ready! Built with commit 6a940c3 |
|
Looks like I have some cleanup to do: the feed doesn't validate. Edit: It does validate, but we have some suggestions. |
|
It's not my favorite either but then I never have seen a pretty config on any real-world project. The config could be moved to a separate module but I'm not sure that's any better |
|
That's kinda where I'm at. My site has a If you think this is good to go, I give it 👍 . |
|
Deploy preview ready! Built with commit 6a940c3 |
|
Looking good!
|
This was referenced Mar 16, 2018
This was referenced Mar 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not 100% on-board with defining logic in
gatsby-config. What do you think?Otherwise, the API exposed by the feed plugin makes this very simple to do.