Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve hot reloading for hooks #16534

Closed
sidharthachatterjee opened this issue Aug 11, 2019 · 1 comment
Closed

Improve hot reloading for hooks #16534

sidharthachatterjee opened this issue Aug 11, 2019 · 1 comment
Labels
help wanted Issue with a clear description that the community can help with.

Comments

@sidharthachatterjee
Copy link
Contributor

react-hot-loader/webpack currently gets applied to all of node_modules

We should apply this only to react-dom

This should do two things

  • speed up develop
  • fix issue where everything breaks if there is node_modules in src

Related

Follow up to #13713 and gaearon/react-hot-loader#1309

Attempted in #16146
@sidharthachatterjee sidharthachatterjee added help wanted Issue with a clear description that the community can help with. type: feature or enhancement labels Aug 11, 2019
@sidharthachatterjee sidharthachatterjee mentioned this issue Aug 11, 2019
Closed
@sidharthachatterjee
Copy link
Contributor Author

Done in #16546 thanks to @theKashey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Issue with a clear description that the community can help with.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sidharthachatterjee