Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(babel-preset-gatsby-package): Add corejs to config #17723

Merged
merged 5 commits into from Sep 18, 2019
Merged

fix(babel-preset-gatsby-package): Add corejs to config #17723

merged 5 commits into from Sep 18, 2019

Conversation

zant
Copy link
Contributor

@zant zant commented Sep 18, 2019 •
edited

Description

This is a warning in development about a missing corejs config in babel, the issue below tracks down the source of the problem, and this fix quiets it down, thanks!

Edit: I specified the version 3 as it seems to be the recommended version on the docs (here)

Related Issues

Fixed #17706

@zant zant requested a review from a team as a code owner September 18, 2019 19:34
wardpeet
wardpeet previously requested changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're currently using version 2 everywhere as we don't want to upgrade yet. Core-js 3 has fixed some browser targets which sadly make everything bigger.

You'll also want to add core-js as a dependency.

packages/babel-preset-gatsby-package/index.js Outdated Show resolved Hide resolved
zant and others added 2 commits September 18, 2019 15:45
@zant
Copy link
Contributor Author

zant commented Sep 18, 2019 •
edited

Oh sorry, just committed the changes, thanks for explaining it!

I think now is ready :)

@zant zant changed the title fix(babel-preset-gatsby-package): Add corejs to config fix(babel-preset-gatsby-package): Add corejs to config (WIP) Sep 18, 2019
@zant zant changed the title fix(babel-preset-gatsby-package): Add corejs to config (WIP) fix(babel-preset-gatsby-package): Add corejs to config Sep 18, 2019
@zant zant requested a review from wardpeet September 18, 2019 21:48
@zant @sidharthachatterjee
Update packages/babel-preset-gatsby-package/package.json
b5457e4 
Co-Authored-By: Sidhartha Chatterjee <me@sidharthachatterjee.com>
sidharthachatterjee
sidharthachatterjee approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! 🙌

@sidharthachatterjee sidharthachatterjee added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Sep 18, 2019
@zant
Copy link
Contributor Author

zant commented Sep 18, 2019

Thanks to you guys! Super glad to contribute 😄

@gatsbybot gatsbybot merged commit 889ae3a into gatsbyjs:master Sep 18, 2019
@gatsbot
Copy link

gatsbot bot commented Sep 18, 2019

Holy buckets, @gonzarodriguezt — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@sidharthachatterjee sidharthachatterjee mentioned this pull request Sep 18, 2019
Merged
@baerrach
Copy link

Cheers!
What does the release process look like?
That is, when can I start using it :P

@zant zant deleted the fix-babel-preset-gatsby-package-corejs branch September 18, 2019 22:55
@pieh
Copy link
Contributor

pieh commented Sep 20, 2019

@baerrach sorry for late reply - I'm currently publishing, so it should be out in few minutes, will post new comment when it's done

@pieh
Copy link
Contributor

pieh commented Sep 20, 2019

babel-preset-gatsby-package@0.2.5 is published!

@baerrach
Copy link

baerrach commented Sep 20, 2019 •
edited

Look at that lack of warnings!

Thanks.

LOLdevelopr pushed a commit to LOLdevelopr/gatsby-1 that referenced this pull request Sep 21, 2019
@zant @sidharthachatterjee @LOLdevelopr
fix(babel-preset-gatsby-package): Add corejs to config (gatsbyjs#17723)
72d2c02 
* Add corejs to babel-preset-gatsby-package config

* Update packages/babel-preset-gatsby-package/index.js

Co-Authored-By: Ward Peeters <ward@coding-tech.com>

* Add corejs as a dependency

* Update snapshot

* Update packages/babel-preset-gatsby-package/package.json

Co-Authored-By: Sidhartha Chatterjee <me@sidharthachatterjee.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidharthachatterjee sidharthachatterjee sidharthachatterjee approved these changes

@wardpeet wardpeet Awaiting requested review from wardpeet

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

babel-preset-gatsby-package doesnt specify corejs in babel preset
6 participants
@zant @baerrach @pieh @wardpeet @sidharthachatterjee @gatsbybot