Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby): support nullish coalescing operator in gatsby #20010

Merged
merged 2 commits into from Dec 9, 2019

Conversation

pvdz
Copy link
Contributor

@pvdz pvdz commented Dec 9, 2019

This means we can do a ?? b in node now (this should not affect output of, say, webpack).

Note that the ?? operator (together with the ?. operator, which we already added earlier) have been accepted to be added to the JS spec. For all intentions and purposes; that means it's now part of JS.

This means we can do `a ?? b` in node now (this should not affect output of, say, webpack).

Note that the `??` operator (together with the `?.` operator, which we already added earlier) have been accepted to be added to the JS spec. For all intentions and purposes; that means it's now part of JS.
@pvdz pvdz requested a review from a team as a code owner December 9, 2019 09:25
@pvdz
Copy link
Contributor Author

pvdz commented Dec 9, 2019

(Not sure whether this is feat or chore, since it's merely including the Babel plugin to enable it)

@pvdz pvdz added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Dec 9, 2019
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

blainekasten
blainekasten previously approved these changes Dec 9, 2019
@gatsbybot gatsbybot merged commit a898a77 into master Dec 9, 2019
@delete-merged-branch delete-merged-branch bot deleted the questions-op branch December 9, 2019 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants