fix(babel-preset-gatsby-package): remove node-env check as it's alway… #20509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wardpeet
added
the
bot: merge on green
m-allanson
reviewed
Jan 9, 2020
| browsers: IS_PRODUCTION | ||
| ? [`last 4 versions`, `safari >= 7`, `ie >= 9`] | ||
| : [`last 2 versions`, `not ie <= 11`, `not android 4.4.3`], | ||
| browsers: [`last 2 versions`, `not ie <= 11`, `not android 4.4.3`], |
There was a problem hiding this comment.
Will this change the client-side JS that's output during a build?
There was a problem hiding this comment.
No that's babel-preset-gatsby :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s false
Description
I've been upgrading reactjs.org to the latest gatsby version (see reactjs/react.dev#2137). Everything worked fine except when I run it using nvmrc (which is set to node 8) it breaks on bad syntax.
Our babel preset has been wrong for a while. Whenever we publish we don't have NODE_ENV or BABEL_ENV set so we publish telling babel to use the current version instead of node 8. 😱
This fixes that 👍