Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-sitemap): allow paths with trailing slash in exclude option #20625

Merged
merged 2 commits into from Jan 15, 2020
Merged

fix(gatsby-plugin-sitemap): allow paths with trailing slash in exclude option #20625

merged 2 commits into from Jan 15, 2020

Conversation

notzenox
Copy link
Contributor

Now gatsby-plugin-sitemap treats /foo/bar/ and /foo/bar as the same,
which removes unnecessary confusion when using the exclude option,
as previously gatsby-plugin-sitemap wouldn't work correctly with trailing slashes in exclude option.

Also fixed some inconsistencies in README.md

…de` option

Now `gatsby-plugin-sitemap` treats `/foo/bar/` and `/foo/bar` as the same,
which removes unnecessary confusion when using the `exclude` option.
@notzenox notzenox requested review from a team as code owners January 15, 2020 15:21
Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my end! Will wait for @gatsbyjs/core to merge.

Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing slashes often cause weird issues but let's hope we won't see any 🤞 (at least I don't see any at the moment). Let's get this merged, thanks for the PR!

@vladar vladar added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jan 15, 2020
@gatsbybot gatsbybot merged commit ba99607 into gatsbyjs:master Jan 15, 2020
@gatsbot
Copy link

gatsbot bot commented Jan 15, 2020

Holy buckets, @masterzenox — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants