Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will gatsby move back to react router with new v6? #21544

Closed
kaushalyap opened this issue Feb 18, 2020 · 8 comments
Closed

Will gatsby move back to react router with new v6? #21544

kaushalyap opened this issue Feb 18, 2020 · 8 comments
Labels
type: question or discussion Issue discussing or asking a question about Gatsby

Comments

@kaushalyap
Copy link

kaushalyap commented Feb 18, 2020

Will gatsby move to react router v6 which is much lighter than reach router? Since Reach router will only receive bug fixes and react router will be the surviving project.

react-router-dom@6.0.0-alpha.1 : 2.9 KB
@reach/router@1.3.1 : 6.4 KB
Potential savings : 3.5 KB

@gatsbot gatsbot bot added the type: question or discussion Issue discussing or asking a question about Gatsby label Feb 18, 2020
@LekoArts
Copy link
Contributor

Thank you for opening this!

We're not sure about it yet but definitely consider it. We'll wait until the merge is done and see how the reach project is doing. We track it in this issue: #15277

So can't give you a definitive answer for now.

We're marking this issue as answered and closing it for now but please feel free to comment here if you would like to continue this discussion. We also recommend heading over to our communities if you have questions that are not bug reports or feature requests. We hope we managed to help and thank you for using Gatsby!

@dvakatsiienko
Copy link

Actually, why this issue is closed and didn't get any attention?

React Router 6 will merge Reacth Router into it, so Reach Router is't the good solution as main router for Gatsby.

@medoms
Copy link

medoms commented Sep 18, 2021

Hello, any news on this issue??

I am very interested in moving from Create React App (using react router) to Gatsby using client side only stuff at the beginning. Right now I can see Gatsby using reach router... as both libraries will be merged soon, people in my situation are somehow stuck.

Could anyone shed some light about what plans there are regarding client routers?

Thanks for your time¡¡

@eckdanny
Copy link

eckdanny commented Nov 5, 2021

react-router@6 GA'd today. We just did a PoV migration from a CRA impl to gatsby@4, and react-router@5.x => @reach | static pages was a pain point. If those invariant build errs went away, we and many others could have a very pleasant migration path

@LemUhuru
Copy link

Bumping this, any plans to merge V6?

@LekoArts
Copy link
Contributor

It seems like V6 made a step backwards in accessibility and thus it's not something we should take lightly: https://twitter.com/mmatuzo/status/1456722149260070916

@olliejm
Copy link

olliejm commented Sep 14, 2022

Are there any updates on this? Seeing as @reach/router is presumably dead now, is it not an eventuality that Gatsby will have to move to a different router?

@dan2k3k4
Copy link
Contributor

Looks like a fork for @reach/router was made:
https://github.com/gatsbyjs/reach-router

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: question or discussion Issue discussing or asking a question about Gatsby
Projects
None yet
Development

No branches or pull requests

7 participants