Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): change bash to shell in code language blocks #22899

Merged
merged 9 commits into from Jun 22, 2020

Conversation

muescha
Copy link
Contributor

@muescha muescha commented Apr 7, 2020

@muescha muescha requested review from a team as code owners April 7, 2020 19:33
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added two comments

packages/gatsby-remark-prismjs/README.md Show resolved Hide resolved
packages/gatsby-remark-prismjs/README.md Show resolved Hide resolved
@muescha
Copy link
Contributor Author

muescha commented Apr 15, 2020

good catch.

in line 209 it says it is in both:

If you want a fancy prompt on anything with `shell` or `bash`, you need to import
the following CSS file in `gatsby-browser.js`:

maybe (in a new PR) would be good to add the shell here:

const useCommandLine =
[`bash`].includes(languageName) &&
(prompt.global ||
(outputLines && outputLines.length > 0) ||
promptUserLocal ||
promptHostLocal)

-    [`bash`].includes(languageName) &&
+    [`bash`,`shell`].includes(languageName) &&

MichaelDeBoey
MichaelDeBoey previously approved these changes Apr 18, 2020
MichaelDeBoey
MichaelDeBoey previously approved these changes Apr 19, 2020
Ekwuno
Ekwuno previously approved these changes Apr 20, 2020
Copy link
Contributor

@Ekwuno Ekwuno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed "$" from the shell commands

docs/blog/2020-01-08-git-workflows/index.md Outdated Show resolved Hide resolved
docs/blog/2020-01-08-git-workflows/index.md Outdated Show resolved Hide resolved
docs/blog/2020-01-08-git-workflows/index.md Outdated Show resolved Hide resolved
docs/blog/2020-01-08-git-workflows/index.md Outdated Show resolved Hide resolved
docs/blog/2020-01-08-git-workflows/index.md Outdated Show resolved Hide resolved
@MichaelDeBoey MichaelDeBoey dismissed stale reviews from Ekwuno and themself via 0456fb6 April 20, 2020 20:28
docs/blog/2020-01-08-git-workflows/index.md Outdated Show resolved Hide resolved
docs/blog/2020-01-08-git-workflows/index.md Outdated Show resolved Hide resolved
@muescha
Copy link
Contributor Author

muescha commented Apr 29, 2020

i think all requested changes are solved...

MichaelDeBoey
MichaelDeBoey previously approved these changes Apr 29, 2020
@muescha muescha dismissed LekoArts’s stale review May 8, 2020 18:10

fixed in: #23256 fix(gatsby-remark-prismjs): Update useCommandLine

# Conflicts:
#	docs/blog/2018-04-04-gatsby-contentful-starter-tutorial/index.md
#	docs/blog/2020-01-08-git-workflows/index.md
@muescha
Copy link
Contributor Author

muescha commented May 21, 2020

merged from master

Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LekoArts LekoArts merged commit 6b6b2f2 into gatsbyjs:master Jun 22, 2020
@muescha muescha deleted the muescha/fix/docs-bash-to-shell branch June 22, 2020 14:22
@muescha
Copy link
Contributor Author

muescha commented Jun 22, 2020

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants