Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(optimize-hook-destructuring): handle skipped items #23438

Merged
merged 1 commit into from Apr 24, 2020
Merged

fix(optimize-hook-destructuring): handle skipped items #23438

merged 1 commit into from Apr 24, 2020

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Apr 23, 2020

Description

This fixes hook destructuring for cases when some elements are skipped - for example:

const [, setCount] = useState(0);

Related Issues

Fixes #23413

@pieh pieh requested a review from a team as a code owner April 23, 2020 21:52
blainekasten
blainekasten approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@blainekasten blainekasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@pieh pieh merged commit 2cf2dc5 into master Apr 24, 2020
@delete-merged-branch delete-merged-branch bot deleted the ohd-skipped-items branch April 24, 2020 17:07
@pieh pieh mentioned this pull request May 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladar vladar vladar left review comments

@blainekasten blainekasten blainekasten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

optimize-hook-destructuring throws when skipping some items
3 participants
@pieh @vladar @blainekasten