fix(gatsby-plugin-mdx): mdxrender should not accept components #24271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
floAr
changed the title
laurieontech
added
topic: MDX
and removed
status: triage needed
LekoArts
changed the title
laurieontech
approved these changes
Sep 9, 2020
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
…yjs#24271) * Remove 'components' from MDXRenderer signature Work for gatsbyjs#21682 * Removed 'components' from MDXRenderer type * removed components * removed unneeded extra imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing the components from MDXRenderer based on discussion in #21682
Documentation
As far as i can see documentation is fine, as https://www.gatsbyjs.org/packages/gatsby-plugin-mdx/#mdxprovider already has no mention of 'components'
Related Issues
Fixes #21682