Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-mdx): Ensure getNodesByType helper is passed to gatsbyRemarkPlugins #24516

Merged
merged 1 commit into from May 27, 2020

Conversation

kamranayub
Copy link
Contributor

Description

Ensures getNodesByType is passed on to Gatsby Remark plugins

Documentation

Docs already exist that suggest this should be passed on (see issue).

Related Issues

Fixes #24400

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 26, 2020
@kamranayub
Copy link
Contributor Author

I think this is all that needs to change but I can test it locally before marking Ready for Review. I could see about adding a test as well perhaps.

@kamranayub
Copy link
Contributor Author

Confirmed this fixes my plugin if I try and destructure getNodesByType

@kamranayub kamranayub marked this pull request as ready for review May 27, 2020 01:06
@kamranayub kamranayub requested a review from a team as a code owner May 27, 2020 01:06
@kamranayub kamranayub changed the title fix(gatsby-plugin-mdx): Pass getNodesByType fix(gatsby-plugin-mdx): Ensure getNodesByType helper is passed to gatsbyRemarkPlugins May 27, 2020
@johno johno added topic: MDX and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 27, 2020
@laurieontech
Copy link
Contributor

Looks good! Thanks!

@laurieontech laurieontech merged commit c62d2fd into gatsbyjs:master May 27, 2020
@gatsbot
Copy link

gatsbot bot commented May 27, 2020

Holy buckets, @kamranayub — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@kamranayub kamranayub deleted the patch-1 branch May 27, 2020 14:40
johno pushed a commit to johno/gatsby that referenced this pull request May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gatsby-plugin-mdx: getNodesByType is not passed to remark plugins
3 participants