Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-link): Fail gracefully on empty to prop #24745

Merged
merged 2 commits into from Jun 3, 2020
Merged

fix(gatsby-link): Fail gracefully on empty to prop #24745

merged 2 commits into from Jun 3, 2020

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Jun 3, 2020

Adds null check so that an empty to prop isn't fatal, but instead warns

@ascorbic ascorbic requested a review from a team as a code owner June 3, 2020 10:55
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 3, 2020
@ascorbic ascorbic merged commit 700cff7 into master Jun 3, 2020
@lannonbr lannonbr deleted the fix/link-to-null-check branch June 3, 2020 13:05
@ascorbic ascorbic removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvdz pvdz pvdz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ascorbic @pvdz