Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(gatsby-plugin-mdx): improve babel attr sub-plugin of mdx #25677

Merged
merged 3 commits into from Jul 10, 2020
Merged

perf(gatsby-plugin-mdx): improve babel attr sub-plugin of mdx #25677

merged 3 commits into from Jul 10, 2020

Conversation

pvdz
Copy link
Contributor

@pvdz pvdz commented Jul 10, 2020

Small improvement to a babel plugin of the mdx plugin and some refactoring while I was there (separate commits).

Mainly changes a large object into a Map and improves lookups and caching.

@pvdz pvdz requested a review from a team as a code owner July 10, 2020 10:01
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 10, 2020
@pvdz pvdz changed the title Mdx jsx plugin perf(gatsby-plugin-mdx): improve babel attr sub-plugin of mdx Jul 10, 2020
@pvdz pvdz added topic: MDX topic: performance Related to runtime & build performance status: needs core review Currently awaiting review from Core team member and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jul 10, 2020
@gatsby-cloud-staging
Copy link

Your pull request can be previewed in Gatsby Cloud: https://build-d14782c0-ac08-4670-a0e2-62eb2c94152a.staging-previews.gtsb.io

wardpeet
wardpeet approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Still wondering why this isn't living in mdx itself but 🤷

@pvdz pvdz added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jul 10, 2020
@gatsbybot gatsbybot merged commit f2c0bd0 into master Jul 10, 2020
@delete-merged-branch delete-merged-branch bot deleted the mdx-jsx-plugin branch July 10, 2020 10:29
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
@ViCo0TeCH
perf(gatsby-plugin-mdx): improve babel attr sub-plugin of mdx (gatsby…
29801f1 
…js#25677)

* perf(gatsby-plugin-jsx): Use a map instead of an object in the jsx attr babel plugin

* Cache the name

* Do not overwrite unneessarily
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes status: needs core review Currently awaiting review from Core team member topic: performance Related to runtime & build performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pvdz @wardpeet @gatsbybot