Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-mdx): Specify new minimum peerDep version for MDX #25798

Merged
merged 1 commit into from Jul 16, 2020
Merged

fix(gatsby-plugin-mdx): Specify new minimum peerDep version for MDX #25798

merged 1 commit into from Jul 16, 2020

Conversation

johno
Copy link
Contributor

@johno johno commented Jul 16, 2020

We recently began using a new API in MDX with #25437 which
doesn't exist for all versions below 1.5.9. This updates the
peer dep for MDX to ensure that the new minimum version is
specified.

Fixes #25691

@johno
fix(gatsby-plugin-mdx): Specify new minimum peerDep version for MDX
a027104 
We recently began using a new API in MDX with #25437 which
doesn't exist for all versions below 1.5.9. This updates the
peer dep for MDX to ensure that the new minimum version is
specified.

Fixes #25691
@johno johno requested a review from a team as a code owner July 16, 2020 17:55
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 16, 2020
@johno johno removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 16, 2020
@gatsby-cloud-staging
Copy link

Your pull request can be previewed in Gatsby Cloud: https://build-65e46a73-75ca-4def-beae-67cc9b289bf1.staging-previews.gtsb.io

laurieontech
laurieontech approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will wait for tests but this seems fine to me.

@laurieontech laurieontech merged commit ab5f80a into master Jul 16, 2020
@delete-merged-branch delete-merged-branch bot deleted the bump-mdx-peer-dep branch July 16, 2020 18:20
stefcameron
stefcameron approved these changes Jul 16, 2020
View reviewed changes
Copy link

@stefcameron stefcameron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

johno added a commit that referenced this pull request Jul 16, 2020
@johno
Revert "fix(gatsby-plugin-mdx): Specify new minimum peerDep version f…
734bbfc 
…or MDX (#25798)"

This reverts commit ab5f80a.
@laurieontech laurieontech mentioned this pull request Jul 16, 2020
Merged
laurieontech pushed a commit that referenced this pull request Jul 16, 2020
@johno
Revert "fix(gatsby-plugin-mdx): Specify new minimum peerDep version f…
e7a9846 
…or MDX (#25798)" (#25800)

This reverts commit ab5f80a.

Co-authored-by: John Otander <johnotander@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefcameron stefcameron stefcameron approved these changes

@laurieontech laurieontech laurieontech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gatsby-plugin-mdx peer dep on mdx-js/mdx must be increased to ^1.5.9
3 participants
@johno @stefcameron @laurieontech