Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(gatsby-plugin-mdx): performance changes #26004

Merged
merged 7 commits into from Jul 30, 2020
Merged

perf(gatsby-plugin-mdx): performance changes #26004

merged 7 commits into from Jul 30, 2020

Conversation

laurieontech
Copy link
Contributor

This is the original PR plus some changes for backwards compatibility. There is a still a race condition in this code we need to solve for.

Fixes #25975

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 24, 2020
@TylerBarnes TylerBarnes changed the title gatsby-plugin-mdx performance changes perf(gatsby-plugin-mdx): performance changes Jul 24, 2020
@TylerBarnes TylerBarnes added topic: internal and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jul 24, 2020
@gatsbyjs gatsbyjs deleted a comment from gatsby-cloud-staging bot Jul 29, 2020
@gatsbyjs gatsbyjs deleted a comment from gatsby-cloud-staging bot Jul 29, 2020
@pvdz
Copy link
Contributor

pvdz commented Jul 29, 2020

Thank you, @laurieontech :D I like your approach better than what I had in mind initially. I added the remainder of the original PR and I expect that tests will pass and this is ready to go, again.

@pvdz pvdz marked this pull request as ready for review July 29, 2020 12:49
@pvdz pvdz requested a review from a team as a code owner July 29, 2020 12:49
@gatsbyjs gatsbyjs deleted a comment from gatsby-cloud bot Jul 29, 2020
@gatsbyjs gatsbyjs deleted a comment from gatsby-cloud bot Jul 29, 2020
@gatsbyjs gatsbyjs deleted a comment from gatsby-cloud bot Jul 29, 2020
@pvdz pvdz marked this pull request as draft July 29, 2020 13:34
@gatsbyjs gatsbyjs deleted a comment from gatsby-cloud bot Jul 29, 2020
@laurieontech laurieontech marked this pull request as ready for review July 29, 2020 16:52
Copy link
Contributor

@johno johno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recent MDX PR changed function signature of createMDXNode
4 participants