feat(gatsby-core-utils): Add node.js export, and move site-metadata into its own function #26237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
ascorbic
added
status: needs core review
Gatsby Cloud Build Reportclient-only-paths 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 18s PerformanceLighthouse report
|
Gatsby Cloud Build Reportusing-styled-components 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 11s PerformanceLighthouse report
|
Gatsby Cloud Build Reportusing-reach-skip-nav 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 20s PerformanceLighthouse report
|
Gatsby Cloud Build Reportgatsby-master 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 16m PerformanceLighthouse report
|
ascorbic
force-pushed
the
feat/site-metadata
branch
from
87ea536
to
29cdd16
Compare
Gatsby Cloud Build Reportgatsby 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 20m |
pvdz
previously approved these changes
Aug 5, 2020
|
|
||
| export async function updateSiteMetadata( | ||
| metadata: ISiteMetadata, | ||
| merge = true |
There was a problem hiding this comment.
Nit
I would kind of suggest to not use a default and to use constants to prevent magic variables and "the boolean trap"-problem.
export const AND_MERGE = true
export const NOT_MERGE = falseor smth, or to export a version of this function that passes on false for you
export async function updateSiteMetadataAndMerge(
metadata: ISiteMetadata
) {
return updateSiteMetadata(metadata, true)
}etc
Comment on lines
21
to
22
| const oldMetadata = (await getSiteMetadata(metadata.sitePath)) || {} | ||
| metadata = { ...oldMetadata, ...metadata } |
There was a problem hiding this comment.
Nit
Suggested change
| const oldMetadata = (await getSiteMetadata(metadata.sitePath)) || {} | |
| metadata = { ...oldMetadata, ...metadata } | |
| const oldMetadata = await getSiteMetadata(metadata.sitePath) | |
| if (oldMetadata) { | |
| metadata = { ...oldMetadata, ...metadata } | |
| } |
mxstbr
previously approved these changes
Aug 10, 2020
Gatsby Cloud Build Reportgatsby 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 3h PerformanceLighthouse report
|
wardpeet
force-pushed
the
feat/site-metadata
branch
from
ca47529
to
fd8c610
Compare
laurieontech
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an export for node.js-specific functions. It also adds new
updateSIteMetadataandgetSiteMetadata, which use service-lock.