feat(gatsby): Support React 17's new JSX Transform #26652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Gatsby Cloud Build Reportusing-reach-skip-nav 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 21s PerformanceLighthouse report
|
Gatsby Cloud Build Reportclient-only-paths 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 18s PerformanceLighthouse report
|
Gatsby Cloud Build Reportusing-styled-components 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 20s PerformanceLighthouse report
|
Gatsby Cloud Build Reportgatsby 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 22m |
wardpeet
changed the title
wardpeet
suggested changes
Aug 27, 2020
wardpeet
added
topic: frontend
blainekasten
force-pushed
the
react/jsx-transform-v17
branch
from
72d1138
to
357a858
Compare
blainekasten
removed
the
status: awaiting author response
wardpeet
approved these changes
Aug 28, 2020
wardpeet
added
the
bot: merge on green
|
Great work! |
|
@marcobiedermann I noticed the same thing. @blainekasten Do you have any suggestion? We might be able to contribute. |
This was referenced Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
React has a new JSX transformation setup. See the blog post here.
Dan Abramov and Luna Ruan from the React core team reached out and asked if we could add support for it and that is what this PR does!
To test it out you can install
gatsby@jsx-transformFrom initial tests, if you have React 17 installed in your gatsby project, you are able to omit the classic
import React from 'react'statement with this new transform. And if you use React 16, the old functionality of requiring that import is still in place.Future:
runtime: automaticall the timeDocumentation
This really shouldn't matter for the end user. It's just a code transformation optimization.
Related Issues